From b1f0f02ce311fd54e05687b7785dd98484093309 Mon Sep 17 00:00:00 2001 From: Naseem <24660299+naseemkullah@users.noreply.github.com> Date: Fri, 1 Oct 2021 11:08:32 -0400 Subject: [PATCH] refactor(integrations): extraerrorata --- packages/integrations/src/extraerrordata.ts | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/packages/integrations/src/extraerrordata.ts b/packages/integrations/src/extraerrordata.ts index 38e32a469b8c..0959f30e95b2 100644 --- a/packages/integrations/src/extraerrordata.ts +++ b/packages/integrations/src/extraerrordata.ts @@ -75,7 +75,6 @@ export class ExtraErrorData implements Integration { * Extract extra information from the Error object */ private _extractErrorData(error: ExtendedError): { [key: string]: unknown } | null { - let result = null; // We are trying to enhance already existing event, so no harm done if it won't succeed try { const nativeKeys = ['name', 'message', 'stack', 'line', 'column', 'fileName', 'lineNumber', 'columnNumber']; @@ -84,18 +83,15 @@ export class ExtraErrorData implements Integration { if (errorKeys.length) { const extraErrorInfo: { [key: string]: unknown } = {}; for (const key of errorKeys) { - let value = error[key]; - if (isError(value)) { - value = (value as Error).toString(); - } - extraErrorInfo[key] = value; + const value = error[key]; + extraErrorInfo[key] = isError(value) ? (value as Error).toString() : value; } - result = extraErrorInfo; + return extraErrorInfo; } } catch (oO) { logger.error('Unable to extract extra data from the Error object:', oO); } - return result; + return null; } }