refactor(integrations): extraerrordata #4024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naseemkullah
force-pushed
the
refactor-extraerrordata
branch
from
ba2c9c1 to
2385359
Compare
naseemkullah
changed the title
naseemkullah
force-pushed
the
refactor-extraerrordata
branch
from
2385359 to
bf3f289
Compare
AbhiPrasad
reviewed
Oct 1, 2021
| try { | ||
| const nativeKeys = ['name', 'message', 'stack', 'line', 'column', 'fileName', 'lineNumber', 'columnNumber']; | ||
| const errorKeys = Object.getOwnPropertyNames(error).filter(key => nativeKeys.indexOf(key) === -1); | ||
| const errorKeys = Object.getOwnPropertyNames(error).filter(key => !nativeKeys.includes(key)); |
Member
There was a problem hiding this comment.
Think we can’t use .includes because of IE, but might be taken care of when transpiled to the es5 bundle. @kamilogorek can you confirm?
Contributor
There was a problem hiding this comment.
Exactly, we cannot. It's not transpiled, so we'd end up with requiring people to add polyfills for it.
naseemkullah
changed the title
naseemkullah
force-pushed
the
refactor-extraerrordata
branch
from
bf3f289 to
b1f0f02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just 4 fun