From 7ac1381c863155127ffdd164c27a11d723c84ecc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kamil=20Og=C3=B3rek?= Date: Mon, 21 Jun 2021 11:29:01 +0200 Subject: [PATCH 1/2] fix: Update ExtractedNodeRequestData to include valid query_params for tracesSampler --- packages/types/src/misc.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/types/src/misc.ts b/packages/types/src/misc.ts index 0ad53d17fe14..bc94e76ebbc0 100644 --- a/packages/types/src/misc.ts +++ b/packages/types/src/misc.ts @@ -1,3 +1,5 @@ +import { QueryParams } from './request'; + /** * Data extracted from an incoming request to a node server */ @@ -17,7 +19,7 @@ export interface ExtractedNodeRequestData { cookies?: { [key: string]: string }; /** The request's query string, without the leading '?' */ - query_string?: string; + query_string?: QueryParams; /** Any data sent in the request's body, as a JSON string */ data?: string; From db0b24e7cd00a0f36001e5acb854e2bf21679c40 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kamil=20Og=C3=B3rek?= Date: Mon, 21 Jun 2021 11:30:39 +0200 Subject: [PATCH 2/2] Update misc.ts --- packages/types/src/misc.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/types/src/misc.ts b/packages/types/src/misc.ts index bc94e76ebbc0..916aaceb5a4a 100644 --- a/packages/types/src/misc.ts +++ b/packages/types/src/misc.ts @@ -18,7 +18,7 @@ export interface ExtractedNodeRequestData { /** String representing the cookies sent along with the request */ cookies?: { [key: string]: string }; - /** The request's query string, without the leading '?' */ + /** The request's query params */ query_string?: QueryParams; /** Any data sent in the request's body, as a JSON string */