fix(sessions): Do not track sessions if not enabled #3686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
Fixes #3685 The patch updates the @sentry/core baseClient to not send sessions to Sentry if it is disabled. This makes sessions match the behaviour of events and integrations (both of which get disabled when the enabled option is set to false).
AbhiPrasad
force-pushed
the
abhi-enabled-session-tracking
branch
from
22bae37 to
7091397
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3685
The patch updates the @sentry/core baseClient to not send sessions
to Sentry if it is disabled. This makes sessions match the behaviour
of events and integrations (both of which get disabled when the
enabled option is set to false).
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).