Skip to content

fix: Do not trigger session on meaningless navigation #3608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2021
Merged

fix: Do not trigger session on meaningless navigation #3608

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
041a71e
fix: Normalize session duration rounding; Dont trigger session on ini…
kamilogorek May 27, 2021
ce3faab
Update packages/browser/src/sdk.ts
kamilogorek May 27, 2021
91c7655
Revert changes to packages/hub/src/session.ts
rhcarvalho May 28, 2021
7825f74
Merge branch 'master' into session-fixes
rhcarvalho May 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/browser/src/sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,11 @@ function startSessionTracking(): void {

// We want to create a session for every navigation as well
addInstrumentationHandler({
callback: () => {
callback: ({ from, to }) => {
// Don't create an additional session for the initial route or if the location did not change
if (from === undefined || from === to) {
return;
}
hub.startSession();
hub.captureSession();
},
Expand Down