feat(nextjs): Automatic performance monitoring #3586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
Member
lobsterkatie
requested changes
May 24, 2021
Member
lobsterkatie
left a comment
lobsterkatie
left a comment
There was a problem hiding this comment.
Besides merging master (required for some code)
Noted changes are from 15a2aa2, 84d05f4 and 3290289, which are all contained in #3586 (files) and #3586 (files)
The main nextjs performance feature branch is up to date with master. Can you please rebase on that, so that this PR only has your changes? That's much easier than trying to keep track of which commits and files count towards the PR and which don't.
For ease of use, I make it so that for client-side tracing nextRouterInstrumentation is always turned on
AbhiPrasad
force-pushed
the
iker/nextjs-client-perf-auto
branch
from
3290289 to
5f05c5b
Compare
Member
|
Rebased to make changes easier to see. |
HazAT
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides merging master (required for some code), this PR adds performance monitoring on the frontend automatically, requiring no action from the user.