Skip to content

fix: Mark span as failed when fetch API call fails #3351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2021
Merged

fix: Mark span as failed when fetch API call fails #3351

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fe9411
fix: Mark span as failed when fetch API call fails
kamilogorek Mar 29, 2021
4a79983
Merge branch 'master' into span-status
kamilogorek Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/tracing/src/browser/request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { getCurrentHub } from '@sentry/hub';
import { addInstrumentationHandler, isInstanceOf, isMatchingPattern } from '@sentry/utils';

import { Span } from '../span';
import { SpanStatus } from '../spanstatus';
import { getActiveTransaction, hasTracingEnabled } from '../utils';

export const DEFAULT_TRACING_ORIGINS = ['localhost', /^\//];
Expand Down Expand Up @@ -53,6 +54,7 @@ export interface FetchData {
// TODO Should this be unknown instead? If we vendor types, make it a Response
// eslint-disable-next-line @typescript-eslint/no-explicit-any
response?: any;
error?: unknown;

startTimestamp: number;
endTimestamp?: number;
Expand Down Expand Up @@ -156,11 +158,12 @@ export function fetchCallback(
if (handlerData.endTimestamp && handlerData.fetchData.__span) {
const span = spans[handlerData.fetchData.__span];
if (span) {
const response = handlerData.response;
if (response) {
if (handlerData.response) {
// TODO (kmclb) remove this once types PR goes through
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
span.setHttpStatus(response.status);
span.setHttpStatus(handlerData.response.status);
} else if (handlerData.error) {
span.setStatus(SpanStatus.InternalError);
}
span.finish();

Expand Down