fix: Mark span as failed when fetch API call fails #3351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
Contributor
I think the root cause of #3350 is related to what span is in the scope by the time the error is reported. When we report the error we send the span context of the current span. If the current span is the pageload transaction, then we get what is described in #3350. I'd expect a fix to involve setting the Fetch span in the scope, or somehow using the span context of the Fetch span when reporting the error. |
Contributor
Author
|
@rhcarvalho changed the description as the fix itself is still valid anyway and should be merged, whether it fixes #3350 or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that Fetch API spans have correct status.