From 20df244a51da1680db6fbe7ac23812559750261e Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Mon, 4 Jan 2021 15:44:23 -0800 Subject: [PATCH 01/12] build(ci): Remove TravisCI Travis sprung some surprise billing changes on us, so we are now prioritizing removing TravisCI completely. --- .github/workflows/test.yml | 155 ++++++++++++++++++ .travis.yml | 37 ----- .../browser/test/integration/karma.conf.js | 4 +- scripts/test.sh | 4 +- 4 files changed, 159 insertions(+), 41 deletions(-) create mode 100644 .github/workflows/test.yml delete mode 100644 .travis.yml diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml new file mode 100644 index 000000000000..1dd7b0a3376a --- /dev/null +++ b/.github/workflows/test.yml @@ -0,0 +1,155 @@ +name: 'Build & Test' +on: + push: + branches: + - master + - release/** + pull_request: + +jobs: + job_build: + name: Build + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - uses: actions/setup-node@v1 + - uses: actions/cache@v2 + with: + path: | + ${{ github.workspace }}/node_modules + ${{ github.workspace }}/packages/**/node_modules + ${{ github.workspace }}/packages/**/build + ${{ github.workspace }}/packages/**/dist + ${{ github.workspace }}/packages/**/esm + ${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip + key: ${{ github.sha }} + - name: Install + run: yarn install + - name: Build + run: yarn build + + job_size_check: + name: Size Check + needs: job_build + runs-on: ubuntu-latest + if: ${{ github.head_ref }} + steps: + - uses: actions/checkout@v2 + - uses: actions/setup-node@v1 + - uses: actions/cache@v2 + with: + path: | + ${{ github.workspace }}/node_modules + ${{ github.workspace }}/packages/**/node_modules + ${{ github.workspace }}/packages/**/build + ${{ github.workspace }}/packages/**/dist + ${{ github.workspace }}/packages/**/esm + ${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip + key: ${{ github.sha }} + - uses: andresz1/size-limit-action@v1.4.0 + with: + github_token: ${{ secrets.GITHUB_TOKEN }} + skip_step: build + + job_lint: + name: Lint + needs: job_build + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - uses: actions/setup-node@v1 + - uses: actions/cache@v2 + with: + path: | + ${{ github.workspace }}/node_modules + ${{ github.workspace }}/packages/**/node_modules + ${{ github.workspace }}/packages/**/build + ${{ github.workspace }}/packages/**/dist + ${{ github.workspace }}/packages/**/esm + ${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip + key: ${{ github.sha }} + - run: yarn install + - name: Run Linter + run: yarn lint + + job_unit_test: + name: Test + needs: job_build + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - uses: actions/setup-node@v1 + - uses: actions/cache@v2 + with: + path: | + ${{ github.workspace }}/node_modules + ${{ github.workspace }}/packages/**/node_modules + ${{ github.workspace }}/packages/**/build + ${{ github.workspace }}/packages/**/dist + ${{ github.workspace }}/packages/**/esm + ${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip + key: ${{ github.sha }} + - run: yarn install + - name: Unit Tests + run: yarn test + - uses: codecov/codecov-action@v1 + + job_artifacts: + name: Artifacts Upload + needs: job_build + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - uses: actions/setup-node@v1 + - uses: actions/cache@v2 + with: + path: | + ${{ github.workspace }}/node_modules + ${{ github.workspace }}/packages/**/node_modules + ${{ github.workspace }}/packages/**/build + ${{ github.workspace }}/packages/**/dist + ${{ github.workspace }}/packages/**/esm + ${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip + key: ${{ github.sha }} + - name: Pack + run: yarn pack:changed + - run: yarn install + - name: Archive Artifacts + uses: actions/upload-artifact@v2 + with: + name: ${{ github.sha }} + path: | + ${{ github.workspace }}/packages/browser/build/** + ${{ github.workspace }}/packages/integrations/build/** + ${{ github.workspace }}/packages/tracing/build/** + ${{ github.workspace }}/packages/**/*.tgz + ${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip + + job_browserstack_test: + name: BrowserStack + needs: job_build + runs-on: ubuntu-latest + if: "github.ref == 'refs/heads/master'" + steps: + - uses: actions/checkout@v2 + - uses: actions/setup-node@v1 + - uses: actions/cache@v2 + with: + path: | + ${{ github.workspace }}/node_modules + ${{ github.workspace }}/packages/**/node_modules + ${{ github.workspace }}/packages/**/build + ${{ github.workspace }}/packages/**/dist + ${{ github.workspace }}/packages/**/esm + ${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip + key: ${{ github.sha }} + - run: yarn install + - name: Integration Tests + env: + BROWSERSTACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }} + BROWSERSTACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }} + run: | + cd packages/browser + yarn test:integration:checkbrowsers + yarn test:integration + yarn test:package diff --git a/.travis.yml b/.travis.yml deleted file mode 100644 index cc663a685da8..000000000000 --- a/.travis.yml +++ /dev/null @@ -1,37 +0,0 @@ -git: - depth: false # we need this to make proper releases - -branches: - only: - - master - - /^release\/.+$/ - - /^major\/.+$/ - -install: yarn --ignore-engines --ignore-scripts -os: linux - -language: node_js -dist: bionic - -cache: - yarn: true - directories: - - node_modules - -jobs: - include: - - name: '@sentry/packages - build and test [node v6]' - node_js: '6' - script: scripts/test.sh - - name: '@sentry/packages - build and test [node v8]' - node_js: '8' - script: scripts/test.sh - - name: '@sentry/packages - build and test [node v10]' - node_js: '10' - script: scripts/test.sh - - name: '@sentry/packages - build and test [node v12]' - node_js: '12' - script: scripts/test.sh - - name: '@sentry/packages - build and test [node v14]' - node_js: '14' - script: scripts/test.sh diff --git a/packages/browser/test/integration/karma.conf.js b/packages/browser/test/integration/karma.conf.js index 2f802487c3ba..cd94f5b335c7 100644 --- a/packages/browser/test/integration/karma.conf.js +++ b/packages/browser/test/integration/karma.conf.js @@ -12,8 +12,8 @@ const browsers = isLocalRun ? ["ChromeHeadless"] : Object.keys(customLaunchers); // for each browser here, so that we have a nice distinction of when the tests were run exactly. if (!isLocalRun) { for (const browser in customLaunchers) { - customLaunchers[browser].build = process.env.TRAVIS_BUILD_NUMBER - ? `Travis: ${process.env.TRAVIS_BUILD_NUMBER}` + customLaunchers[browser].build = process.env.GITHUB_RUN_ID + ? `CI: ${process.env.GITHUB_RUN_ID}` : `Manual: ${new Date().toLocaleString()}`; } } diff --git a/scripts/test.sh b/scripts/test.sh index ff98d2485259..4334e2c08c97 100755 --- a/scripts/test.sh +++ b/scripts/test.sh @@ -3,7 +3,7 @@ set -e source ~/.nvm/nvm.sh # We need this check to skip engines check for typescript-tslint-plugin package -if [[ "$(cut -d. -f1 <<< "$TRAVIS_NODE_VERSION")" -le 6 ]]; then +if [[ "$(cut -d. -f1 <<< "$NODE_VERSION")" -le 6 ]]; then nvm use 8 yarn install --ignore-engines --ignore-scripts # current versions of nock don't support node 6 @@ -15,7 +15,7 @@ if [[ "$(cut -d. -f1 <<< "$TRAVIS_NODE_VERSION")" -le 6 ]]; then nvm use 6 # browser can be tested only on Node >= v8 because Karma is not supporting anything older yarn test --ignore="@sentry/tracing" --ignore="@sentry/react" --ignore="@sentry/gatsby" --ignore="@sentry/ember" --ignore="@sentry-internal/eslint-plugin-sdk" --ignore="@sentry-internal/eslint-config-sdk" --ignore="@sentry/serverless" --ignore="@sentry/browser" --ignore="@sentry/integrations" -elif [[ "$(cut -d. -f1 <<< "$TRAVIS_NODE_VERSION")" -le 8 ]]; then +elif [[ "$(cut -d. -f1 <<< "$NODE_VERSION")" -le 8 ]]; then yarn install --ignore-engines --ignore-scripts # ember requires Node >= 10 to build yarn build --ignore="@sentry/ember" --ignore="@sentry/serverless" --ignore="@sentry/gatsby" --ignore="@sentry/react" From 31f8eef11d823dc355b9b42c5f2253edc4d321d4 Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Mon, 4 Jan 2021 15:45:06 -0800 Subject: [PATCH 02/12] oops --- .github/workflows/test.yml | 151 +++---------------------------------- 1 file changed, 12 insertions(+), 139 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 1dd7b0a3376a..3ae9691fc76a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,155 +1,28 @@ -name: 'Build & Test' +name: Test on: push: branches: - master - release/** + - major/** pull_request: jobs: - job_build: - name: Build - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 - - uses: actions/cache@v2 - with: - path: | - ${{ github.workspace }}/node_modules - ${{ github.workspace }}/packages/**/node_modules - ${{ github.workspace }}/packages/**/build - ${{ github.workspace }}/packages/**/dist - ${{ github.workspace }}/packages/**/esm - ${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip - key: ${{ github.sha }} - - name: Install - run: yarn install - - name: Build - run: yarn build - - job_size_check: - name: Size Check - needs: job_build - runs-on: ubuntu-latest - if: ${{ github.head_ref }} - steps: - - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 - - uses: actions/cache@v2 - with: - path: | - ${{ github.workspace }}/node_modules - ${{ github.workspace }}/packages/**/node_modules - ${{ github.workspace }}/packages/**/build - ${{ github.workspace }}/packages/**/dist - ${{ github.workspace }}/packages/**/esm - ${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip - key: ${{ github.sha }} - - uses: andresz1/size-limit-action@v1.4.0 - with: - github_token: ${{ secrets.GITHUB_TOKEN }} - skip_step: build - - job_lint: - name: Lint - needs: job_build - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 - - uses: actions/cache@v2 - with: - path: | - ${{ github.workspace }}/node_modules - ${{ github.workspace }}/packages/**/node_modules - ${{ github.workspace }}/packages/**/build - ${{ github.workspace }}/packages/**/dist - ${{ github.workspace }}/packages/**/esm - ${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip - key: ${{ github.sha }} - - run: yarn install - - name: Run Linter - run: yarn lint - - job_unit_test: + test: name: Test - needs: job_build - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 - - uses: actions/cache@v2 - with: - path: | - ${{ github.workspace }}/node_modules - ${{ github.workspace }}/packages/**/node_modules - ${{ github.workspace }}/packages/**/build - ${{ github.workspace }}/packages/**/dist - ${{ github.workspace }}/packages/**/esm - ${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip - key: ${{ github.sha }} - - run: yarn install - - name: Unit Tests - run: yarn test - - uses: codecov/codecov-action@v1 - - job_artifacts: - name: Artifacts Upload - needs: job_build runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 - - uses: actions/cache@v2 - with: - path: | - ${{ github.workspace }}/node_modules - ${{ github.workspace }}/packages/**/node_modules - ${{ github.workspace }}/packages/**/build - ${{ github.workspace }}/packages/**/dist - ${{ github.workspace }}/packages/**/esm - ${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip - key: ${{ github.sha }} - - name: Pack - run: yarn pack:changed - - run: yarn install - - name: Archive Artifacts - uses: actions/upload-artifact@v2 - with: - name: ${{ github.sha }} - path: | - ${{ github.workspace }}/packages/browser/build/** - ${{ github.workspace }}/packages/integrations/build/** - ${{ github.workspace }}/packages/tracing/build/** - ${{ github.workspace }}/packages/**/*.tgz - ${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip + strategy: + matrix: + node: [6, 8, 10, 12, 14] - job_browserstack_test: - name: BrowserStack - needs: job_build - runs-on: ubuntu-latest - if: "github.ref == 'refs/heads/master'" steps: - uses: actions/checkout@v2 - uses: actions/setup-node@v1 - - uses: actions/cache@v2 with: - path: | - ${{ github.workspace }}/node_modules - ${{ github.workspace }}/packages/**/node_modules - ${{ github.workspace }}/packages/**/build - ${{ github.workspace }}/packages/**/dist - ${{ github.workspace }}/packages/**/esm - ${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip - key: ${{ github.sha }} - - run: yarn install - - name: Integration Tests + node-version: ${{ matrix.node }} + - name: Install + run: yarn install --ignore-engines --ignore-scripts + - name: Test env: - BROWSERSTACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }} - BROWSERSTACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }} - run: | - cd packages/browser - yarn test:integration:checkbrowsers - yarn test:integration - yarn test:package + NODE_VERSION: ${{ matrix.node }} + run: ./scripts/test.sh From 2f021496f5a1f870dc4c86eef184b0a18cbc4a24 Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Mon, 4 Jan 2021 15:52:05 -0800 Subject: [PATCH 03/12] remove yarn install --- .github/workflows/test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3ae9691fc76a..f3d2f1a66c5a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -17,11 +17,11 @@ jobs: steps: - uses: actions/checkout@v2 + - uses: actions/setup-node@v1 with: node-version: ${{ matrix.node }} - - name: Install - run: yarn install --ignore-engines --ignore-scripts + - name: Test env: NODE_VERSION: ${{ matrix.node }} From e988c05aa723f80fe100bd59b7a92708b92bb5e1 Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Mon, 4 Jan 2021 15:54:10 -0800 Subject: [PATCH 04/12] rename --- .github/workflows/{test.yml => ci.yml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/{test.yml => ci.yml} (100%) diff --git a/.github/workflows/test.yml b/.github/workflows/ci.yml similarity index 100% rename from .github/workflows/test.yml rename to .github/workflows/ci.yml From ea29f7ffa2b799590f02a8bfb9bdf53cfaa7a2a0 Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Mon, 4 Jan 2021 15:55:38 -0800 Subject: [PATCH 05/12] nvm install --- .github/workflows/ci.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f3d2f1a66c5a..a9bb42b604fd 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,7 +22,10 @@ jobs: with: node-version: ${{ matrix.node }} + - name: Test env: NODE_VERSION: ${{ matrix.node }} - run: ./scripts/test.sh + run: | + nvm install ${{ matrix.node }} + ./scripts/test.sh From e7762d79fc957ecd697146965b9ff10f397603de Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Mon, 4 Jan 2021 16:09:21 -0800 Subject: [PATCH 06/12] nvm install in scripts/test.sh --- .github/workflows/ci.yml | 6 ++---- scripts/test.sh | 1 + 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a9bb42b604fd..8a3ebd4cb8ef 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,11 +9,11 @@ on: jobs: test: - name: Test + name: build and test runs-on: ubuntu-latest strategy: matrix: - node: [6, 8, 10, 12, 14] + node: [6] steps: - uses: actions/checkout@v2 @@ -22,10 +22,8 @@ jobs: with: node-version: ${{ matrix.node }} - - name: Test env: NODE_VERSION: ${{ matrix.node }} run: | - nvm install ${{ matrix.node }} ./scripts/test.sh diff --git a/scripts/test.sh b/scripts/test.sh index 4334e2c08c97..4745f6068abe 100755 --- a/scripts/test.sh +++ b/scripts/test.sh @@ -4,6 +4,7 @@ source ~/.nvm/nvm.sh # We need this check to skip engines check for typescript-tslint-plugin package if [[ "$(cut -d. -f1 <<< "$NODE_VERSION")" -le 6 ]]; then + nvm install 8 nvm use 8 yarn install --ignore-engines --ignore-scripts # current versions of nock don't support node 6 From 1f568e17768eb840941f5d0bb6c2f2e7d9fc1aec Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Mon, 4 Jan 2021 16:15:57 -0800 Subject: [PATCH 07/12] fix nvm install --- .github/workflows/ci.yml | 13 ++++++++++++- scripts/test.sh | 1 + 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8a3ebd4cb8ef..431d4a76a526 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node: [6] + node: [6, 8, 10, 12, 14] steps: - uses: actions/checkout@v2 @@ -22,6 +22,17 @@ jobs: with: node-version: ${{ matrix.node }} + - uses: actions/cache@v2 + with: + path: | + ${{ github.workspace }}/node_modules + ${{ github.workspace }}/packages/**/node_modules + ${{ github.workspace }}/packages/**/build + ${{ github.workspace }}/packages/**/dist + ${{ github.workspace }}/packages/**/esm + ${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip + key: ${{ github.sha }} + - name: Test env: NODE_VERSION: ${{ matrix.node }} diff --git a/scripts/test.sh b/scripts/test.sh index 4745f6068abe..a6948100519e 100755 --- a/scripts/test.sh +++ b/scripts/test.sh @@ -13,6 +13,7 @@ if [[ "$(cut -d. -f1 <<< "$NODE_VERSION")" -le 6 ]]; then cd ../.. # ember requires Node >= 10 to build yarn build --ignore="@sentry/ember" --ignore="@sentry/serverless" --ignore="@sentry/gatsby" --ignore="@sentry/react" + nvm install 6 nvm use 6 # browser can be tested only on Node >= v8 because Karma is not supporting anything older yarn test --ignore="@sentry/tracing" --ignore="@sentry/react" --ignore="@sentry/gatsby" --ignore="@sentry/ember" --ignore="@sentry-internal/eslint-plugin-sdk" --ignore="@sentry-internal/eslint-config-sdk" --ignore="@sentry/serverless" --ignore="@sentry/browser" --ignore="@sentry/integrations" From 3d76cdbd08b2761122681e7e63d30f13352b6403 Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Tue, 5 Jan 2021 10:13:32 -0800 Subject: [PATCH 08/12] remove cache --- .github/workflows/ci.yml | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 431d4a76a526..7a57024753df 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,17 +22,6 @@ jobs: with: node-version: ${{ matrix.node }} - - uses: actions/cache@v2 - with: - path: | - ${{ github.workspace }}/node_modules - ${{ github.workspace }}/packages/**/node_modules - ${{ github.workspace }}/packages/**/build - ${{ github.workspace }}/packages/**/dist - ${{ github.workspace }}/packages/**/esm - ${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip - key: ${{ github.sha }} - - name: Test env: NODE_VERSION: ${{ matrix.node }} From 708fe1d2ec7817385822f04ed679956b31caf44d Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Tue, 5 Jan 2021 12:06:56 -0800 Subject: [PATCH 09/12] consolidate --- .github/workflows/build.yml | 10 +++++++++- .github/workflows/ci.yml | 29 ----------------------------- 2 files changed, 9 insertions(+), 30 deletions(-) delete mode 100644 .github/workflows/ci.yml diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1dd7b0a3376a..f42904db9e91 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -76,9 +76,14 @@ jobs: name: Test needs: job_build runs-on: ubuntu-latest + strategy: + matrix: + node: [6, 8, 10, 12, 14] steps: - uses: actions/checkout@v2 - uses: actions/setup-node@v1 + with: + node-version: ${{ matrix.node }} - uses: actions/cache@v2 with: path: | @@ -91,7 +96,10 @@ jobs: key: ${{ github.sha }} - run: yarn install - name: Unit Tests - run: yarn test + env: + NODE_VERSION: ${{ matrix.node }} + run: | + ./scripts/test.sh - uses: codecov/codecov-action@v1 job_artifacts: diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml deleted file mode 100644 index 7a57024753df..000000000000 --- a/.github/workflows/ci.yml +++ /dev/null @@ -1,29 +0,0 @@ -name: Test -on: - push: - branches: - - master - - release/** - - major/** - pull_request: - -jobs: - test: - name: build and test - runs-on: ubuntu-latest - strategy: - matrix: - node: [6, 8, 10, 12, 14] - - steps: - - uses: actions/checkout@v2 - - - uses: actions/setup-node@v1 - with: - node-version: ${{ matrix.node }} - - - name: Test - env: - NODE_VERSION: ${{ matrix.node }} - run: | - ./scripts/test.sh From d024bf20bbfc036751ba74abcb4d21aa7429c383 Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Tue, 5 Jan 2021 12:57:42 -0800 Subject: [PATCH 10/12] fix yarn install, add timeout-minutes --- .github/workflows/build.yml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index f42904db9e91..ac80a52fce8b 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -10,6 +10,7 @@ jobs: job_build: name: Build runs-on: ubuntu-latest + timeout-minutes: 15 steps: - uses: actions/checkout@v2 - uses: actions/setup-node@v1 @@ -31,6 +32,7 @@ jobs: job_size_check: name: Size Check needs: job_build + timeout-minutes: 15 runs-on: ubuntu-latest if: ${{ github.head_ref }} steps: @@ -54,6 +56,7 @@ jobs: job_lint: name: Lint needs: job_build + timeout-minutes: 10 runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 @@ -75,6 +78,8 @@ jobs: job_unit_test: name: Test needs: job_build + continue-on-error: true + timeout-minutes: 30 runs-on: ubuntu-latest strategy: matrix: @@ -94,12 +99,10 @@ jobs: ${{ github.workspace }}/packages/**/esm ${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip key: ${{ github.sha }} - - run: yarn install - name: Unit Tests env: NODE_VERSION: ${{ matrix.node }} - run: | - ./scripts/test.sh + run: ./scripts/test.sh - uses: codecov/codecov-action@v1 job_artifacts: @@ -137,6 +140,7 @@ jobs: name: BrowserStack needs: job_build runs-on: ubuntu-latest + timeout-minutes: 15 if: "github.ref == 'refs/heads/master'" steps: - uses: actions/checkout@v2 From af77471ae41ec0716ecfce417879b22c6a58a4e3 Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Tue, 5 Jan 2021 12:57:49 -0800 Subject: [PATCH 11/12] fix browserstack test --- packages/browser/test/integration/browsers.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/browser/test/integration/browsers.js b/packages/browser/test/integration/browsers.js index 8e81160ca7a5..ee226a872545 100644 --- a/packages/browser/test/integration/browsers.js +++ b/packages/browser/test/integration/browsers.js @@ -23,7 +23,7 @@ module.exports = { bs_android_6: { base: "BrowserStack", browser: "Android Browser", - device: "Samsung Galaxy Note 4", + device: "Google Nexus 6", os: "android", os_version: "6.0", real_mobile: true, From 60ae3fb89c1e840aa03821a4dfa07dee3cdde7b1 Mon Sep 17 00:00:00 2001 From: Billy Vong Date: Tue, 5 Jan 2021 16:10:41 -0800 Subject: [PATCH 12/12] Update .github/workflows/build.yml --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ac80a52fce8b..359370cf4f4a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -140,7 +140,7 @@ jobs: name: BrowserStack needs: job_build runs-on: ubuntu-latest - timeout-minutes: 15 + timeout-minutes: 45 if: "github.ref == 'refs/heads/master'" steps: - uses: actions/checkout@v2