fix: Typo in constant name in @sentry/tracing #3058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobsterkatie
approved these changes
Nov 18, 2020
Member
lobsterkatie
left a comment
lobsterkatie
left a comment
There was a problem hiding this comment.
IMHO you could just take it out now. Very much an internal API, and we make no guarantees to keep that stable.
Up to you.
Contributor
size-limit report
|
Contributor
|
It's not and never was exposed publically, don't need to have a fallback. |
defaultRequestInstrumentionOptions => defaultRequestInstrumentationOptions Despite being exported, the old name is not documented and not part of what is considered public API, therefore we remove the old name altogether.
rhcarvalho
force-pushed
the
rhcarvalho/tracing-options-rename
branch
from
181af1c to
5761429
Compare
Contributor
Author
Alright, the old name is gone :) |
HazAT
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultRequestInstrumentionOptions => defaultRequestInstrumentationOptions
Despite being exported, the old name is not documented and not part of
what is considered public API, therefore we remove the old name
altogether.