Skip to content

Conversation

@Empact
Copy link
Contributor

@Empact Empact commented Nov 6, 2020

Consistent with DEFAULT_BREADCRUMBS of src/hub.ts

/**
* Default maximum number of breadcrumbs added to an event. Can be overwritten
* with {@link Options.maxBreadcrumbs}.
*/
const DEFAULT_BREADCRUMBS = 100;

@Empact Empact requested a review from kamilogorek as a code owner November 6, 2020 06:26
@Empact Empact changed the title Fix maxBreadcrumbs doc comment to not the proper default Fix maxBreadcrumbs doc comment to note the proper default Nov 6, 2020
@Empact Empact force-pushed the max-breadcrumb-default branch from 5dc5211 to a5cf3bf Compare November 6, 2020 06:30
Consistent with DEFAULT_BREADCRUMBS of src/hub.ts
@Empact Empact force-pushed the max-breadcrumb-default branch from a5cf3bf to 1f4e7ab Compare November 6, 2020 06:31
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@HazAT HazAT merged commit d8ca29b into getsentry:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants