From 18277ed1edcda4434013e173145998a651994bad Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Thu, 29 Oct 2020 10:04:49 -0700 Subject: [PATCH 1/2] add code as tag --- packages/browser/src/eventbuilder.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/browser/src/eventbuilder.ts b/packages/browser/src/eventbuilder.ts index 706b299fe013..f8a9f12e5397 100644 --- a/packages/browser/src/eventbuilder.ts +++ b/packages/browser/src/eventbuilder.ts @@ -78,7 +78,7 @@ export function eventFromUnknownInput( } if (isDOMError(exception as DOMError) || isDOMException(exception as DOMException)) { // If it is a DOMError or DOMException (which are legacy APIs, but still supported in some browsers) - // then we just extract the name and message, as they don't provide anything else + // then we just extract the name, code, and message, as they don't provide anything else // https://developer.mozilla.org/en-US/docs/Web/API/DOMError // https://developer.mozilla.org/en-US/docs/Web/API/DOMException const domException = exception as DOMException; @@ -87,6 +87,8 @@ export function eventFromUnknownInput( event = eventFromString(message, syntheticException, options); addExceptionTypeValue(event, message); + event.tags = domException.code ? { ...event.tags, 'DOMException.code': String(domException.code) } : event.tags; + return event; } if (isError(exception as Error)) { From 9ddea3ef1906c2cd4bf7bf0de8bac122bb7d35d2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kamil=20Og=C3=B3rek?= Date: Wed, 4 Nov 2020 15:43:29 +0100 Subject: [PATCH 2/2] Update packages/browser/src/eventbuilder.ts --- packages/browser/src/eventbuilder.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/browser/src/eventbuilder.ts b/packages/browser/src/eventbuilder.ts index f8a9f12e5397..36c1f7bc4715 100644 --- a/packages/browser/src/eventbuilder.ts +++ b/packages/browser/src/eventbuilder.ts @@ -87,7 +87,9 @@ export function eventFromUnknownInput( event = eventFromString(message, syntheticException, options); addExceptionTypeValue(event, message); - event.tags = domException.code ? { ...event.tags, 'DOMException.code': String(domException.code) } : event.tags; + if ('code' in domException) { + event.tags = { ...event.tags, 'DOMException.code': `${domException.code}` } + } return event; }