feat: Implement X-Sentry-Rate-Limits handling for browser SDK transports #2962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
rhcarvalho
reviewed
Oct 8, 2020
Contributor
rhcarvalho
left a comment
rhcarvalho
left a comment
There was a problem hiding this comment.
One of the aspects of the X-Sentry-Rate-Limits is that it may come in any response status, not only 429 😮
rhcarvalho
reviewed
Oct 12, 2020
Comment on lines
+143
to
+157
| // 1st event - _isRateLimited - false | ||
| .onCall(0) | ||
| .returns(beforeLimit) | ||
| // 1st event - _handleRateLimit | ||
| .onCall(1) | ||
| .returns(beforeLimit) | ||
| // 2nd event - _isRateLimited - true | ||
| .onCall(2) | ||
| .returns(withinLimit) | ||
| // 3rd event - _isRateLimited - false | ||
| .onCall(3) | ||
| .returns(afterLimit) | ||
| // 3rd event - _handleRateLimit | ||
| .onCall(4) | ||
| .returns(afterLimit); |
Contributor
There was a problem hiding this comment.
L:
This is rather confusing 😕
Co-authored-by: Rodolfo Carvalho <[email protected]>
rhcarvalho
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.