From 066eecb7036972e304e97a2d564f1d9e194f2121 Mon Sep 17 00:00:00 2001 From: JustDoItSascha Date: Thu, 8 Oct 2020 12:53:51 +0200 Subject: [PATCH 1/4] Make @angular/common a peerDependency instead of dependency Solves #2960 --- packages/angular/package.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/angular/package.json b/packages/angular/package.json index 8897ee1a03db..734024de1862 100644 --- a/packages/angular/package.json +++ b/packages/angular/package.json @@ -15,8 +15,10 @@ "publishConfig": { "access": "public" }, + "peerDependencies": { + "@angular/common: "^10.0.3" + }, "dependencies": { - "@angular/common": "^10.0.3", "@angular/core": "^10.0.3", "@angular/router": "^10.0.3", "@sentry/browser": "5.25.0", From be24377d9921dda8fb704fae4bb881aff94c3927 Mon Sep 17 00:00:00 2001 From: JustDoItSascha Date: Thu, 8 Oct 2020 14:59:25 +0200 Subject: [PATCH 2/4] Fix missing quote --- packages/angular/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/angular/package.json b/packages/angular/package.json index 734024de1862..3dfb87b725ad 100644 --- a/packages/angular/package.json +++ b/packages/angular/package.json @@ -16,7 +16,7 @@ "access": "public" }, "peerDependencies": { - "@angular/common: "^10.0.3" + "@angular/common": "^10.0.3" }, "dependencies": { "@angular/core": "^10.0.3", From 64e6c1df875819f801a24f9194c028bc8d6854fe Mon Sep 17 00:00:00 2001 From: JustDoItSascha Date: Sat, 10 Oct 2020 16:15:06 +0200 Subject: [PATCH 3/4] fix: move all angular dependencies to peer- and devDependencies --- packages/angular/package.json | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/angular/package.json b/packages/angular/package.json index 3dfb87b725ad..d20c0c11c8f0 100644 --- a/packages/angular/package.json +++ b/packages/angular/package.json @@ -17,10 +17,10 @@ }, "peerDependencies": { "@angular/common": "^10.0.3" + "@angular/core": "^10.0.3", + "@angular/router": "^10.0.3" }, "dependencies": { - "@angular/core": "^10.0.3", - "@angular/router": "^10.0.3", "@sentry/browser": "5.25.0", "@sentry/types": "5.25.0", "@sentry/utils": "5.25.0", @@ -28,6 +28,9 @@ "tslib": "^1.9.3" }, "devDependencies": { + "@angular/common": "^10.0.3" + "@angular/core": "^10.0.3", + "@angular/router": "^10.0.3", "@sentry-internal/eslint-config-sdk": "5.25.0", "eslint": "7.6.0", "npm-run-all": "^4.1.2", From d63cded13b178268891e115f7242a12dbace2bd3 Mon Sep 17 00:00:00 2001 From: JustDoItSascha Date: Sat, 10 Oct 2020 16:15:31 +0200 Subject: [PATCH 4/4] fix: add missing comma --- packages/angular/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/angular/package.json b/packages/angular/package.json index d20c0c11c8f0..ceee834286da 100644 --- a/packages/angular/package.json +++ b/packages/angular/package.json @@ -16,7 +16,7 @@ "access": "public" }, "peerDependencies": { - "@angular/common": "^10.0.3" + "@angular/common": "^10.0.3", "@angular/core": "^10.0.3", "@angular/router": "^10.0.3" }, @@ -28,7 +28,7 @@ "tslib": "^1.9.3" }, "devDependencies": { - "@angular/common": "^10.0.3" + "@angular/common": "^10.0.3", "@angular/core": "^10.0.3", "@angular/router": "^10.0.3", "@sentry-internal/eslint-config-sdk": "5.25.0",