From 3d9047d8b7c03254a84c444128e27331ca1c6daf Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Thu, 24 Sep 2020 11:01:02 +0200 Subject: [PATCH 1/2] Mention `tracesSampleRate` in Ember docs --- packages/ember/README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/ember/README.md b/packages/ember/README.md index 597384722323..e18bc23cc840 100644 --- a/packages/ember/README.md +++ b/packages/ember/README.md @@ -74,6 +74,8 @@ Aside from configuration passed from this addon into `@sentry/browser` via the ` }; ``` +Note that you have to provide `ENV['@sentry/ember'].sentry.tracesSampleRate` (see [documentation](https://docs.sentry.io/platforms/javascript/#monitor-performance)) for any performance data to be captured. + ### Performance #### Routes If you would like to capture `beforeModel`, `model`, `afterModel` and `setupController` times for one of your routes, @@ -105,7 +107,7 @@ If you would like to change the runloop queue threshold, add the following to yo ``` #### Components -Non-glimmer component render times will automatically get captured. +Non-glimmer component render times will automatically get captured. If you would like to disable component render being instrumented, add the following to your config: ```javascript From cfa6d5419a66560d36207f2a628468005f362a5c Mon Sep 17 00:00:00 2001 From: k-fish Date: Thu, 24 Sep 2020 17:38:48 -0700 Subject: [PATCH 2/2] Include tracesSampleRate for config in readme This should help new users get started faster by including what is needed for performance right away. --- packages/ember/README.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/ember/README.md b/packages/ember/README.md index e18bc23cc840..e2b95248e4ba 100644 --- a/packages/ember/README.md +++ b/packages/ember/README.md @@ -27,11 +27,11 @@ Then add the following config to `config/environment.js` ```javascript ENV['@sentry/ember'] = { sentry: { - dsn: '__DSN__' // replace __DSN__ with your DSN + dsn: '__DSN__' // replace __DSN__ with your DSN, + tracesSampleRate: 1.0, // Be sure to lower this for your production environment } }; ``` - ### Usage To use this SDK, call `InitSentryForEmber` before the application is initialized, in `app.js`. This will load Sentry config from `environment.js` for you. @@ -74,7 +74,6 @@ Aside from configuration passed from this addon into `@sentry/browser` via the ` }; ``` -Note that you have to provide `ENV['@sentry/ember'].sentry.tracesSampleRate` (see [documentation](https://docs.sentry.io/platforms/javascript/#monitor-performance)) for any performance data to be captured. ### Performance #### Routes