Skip to content

fix: Check that performance is available before calling it in RN #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2020
Merged

fix: Check that performance is available before calling it in RN #2924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions packages/utils/src/misc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,14 +271,19 @@ const performanceFallback: CrossPlatformPerformance = {
* Performance wrapper for react native as performance.now() has been found to start off with an unusual offset.
*/
function getReactNativePerformanceWrapper(): CrossPlatformPerformance {
const INITIAL_OFFSET = performance.now();

return {
now(): number {
return performance.now() - INITIAL_OFFSET;
},
timeOrigin: INITIAL_TIME,
};
// Performance only available >= RN 0.63
const { performance } = getGlobalObject<Window>();
if (performance && typeof performance.now === 'function') {
const INITIAL_OFFSET = performance.now();

return {
now(): number {
return performance.now() - INITIAL_OFFSET;
},
timeOrigin: INITIAL_TIME,
};
}
return performanceFallback;
}

export const crossPlatformPerformance: CrossPlatformPerformance = ((): CrossPlatformPerformance => {
Expand Down