Skip to content

fix: Remove Location type to avoid dom lib dependency #2922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2020
Merged

fix: Remove Location type to avoid dom lib dependency #2922

merged 1 commit into from
Sep 18, 2020

Conversation

@jennmueng
Copy link
Member

@jennmueng jennmueng commented Sep 18, 2020 •
edited by HazAT
Loading

This fixes a node typescript build error if dom is not included in types

@jennmueng jennmueng requested a review from HazAT September 18, 2020 09:48
@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2020

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 17.95 KB (-0.01% 🔽)
@sentry/browser - Webpack 18.79 KB (0%)
@sentry/react - Webpack 18.79 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 23.75 KB (0%)

@HazAT HazAT merged commit 0f28601 into master Sep 18, 2020
@HazAT HazAT deleted the fix/remove-dom-lib-dependency branch September 18, 2020 10:06
@kirillgroshkov
Copy link

kirillgroshkov commented Sep 18, 2020

Hey, FYI there are more things that doesn't compile without dom, e.g there's one I reported: #2913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HazAT HazAT HazAT approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jennmueng @kirillgroshkov @HazAT