Skip to content

fix(tracing): Normalize transaction names for express methods to match those of other SDKs #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2020
Merged

fix(tracing): Normalize transaction names for express methods to match those of other SDKs #2832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/node/src/handlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ function extractTransaction(req: { [key: string]: any }, type: boolean | Transac
case 'methodPath':
default: {
const method = request.method.toUpperCase();
return `${method}|${routePath}`;
return `${method} ${routePath}`;
}
}
} catch (_oO) {
Expand Down
6 changes: 3 additions & 3 deletions packages/node/test/handlers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,20 +138,20 @@ describe('parseRequest', () => {
describe('parseRequest.transaction property', () => {
test('extracts method and full route path by default from `originalUrl`', () => {
const parsedRequest: Event = parseRequest({}, mockReq);
expect(parsedRequest.transaction).toEqual('POST|/some/originalUrl');
expect(parsedRequest.transaction).toEqual('POST /some/originalUrl');
});

test('extracts method and full route path by default from `url` if `originalUrl` is not present', () => {
delete mockReq.originalUrl;
const parsedRequest: Event = parseRequest({}, mockReq);
expect(parsedRequest.transaction).toEqual('POST|/some/url');
expect(parsedRequest.transaction).toEqual('POST /some/url');
});

test('fallback to method and `route.path` if previous attempts failed', () => {
delete mockReq.originalUrl;
delete mockReq.url;
const parsedRequest: Event = parseRequest({}, mockReq);
expect(parsedRequest.transaction).toEqual('POST|/path');
expect(parsedRequest.transaction).toEqual('POST /path');
});

test('can extract path only instead if configured', () => {
Expand Down