From d055c200409ae0123015755b8fa61b97e3a3d654 Mon Sep 17 00:00:00 2001
From: Alberto Leal <mail4alberto@gmail.com>
Date: Thu, 20 Aug 2020 19:21:02 -0400
Subject: [PATCH] fix(tracing): Normalize transaction names for express methods
 to match those of other SDKs

---
 packages/node/src/handlers.ts       | 2 +-
 packages/node/test/handlers.test.ts | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/packages/node/src/handlers.ts b/packages/node/src/handlers.ts
index 12ce7205324b..fdeae635ff35 100644
--- a/packages/node/src/handlers.ts
+++ b/packages/node/src/handlers.ts
@@ -113,7 +113,7 @@ function extractTransaction(req: { [key: string]: any }, type: boolean | Transac
       case 'methodPath':
       default: {
         const method = request.method.toUpperCase();
-        return `${method}|${routePath}`;
+        return `${method} ${routePath}`;
       }
     }
   } catch (_oO) {
diff --git a/packages/node/test/handlers.test.ts b/packages/node/test/handlers.test.ts
index b0b66af407b6..c9542850b75a 100644
--- a/packages/node/test/handlers.test.ts
+++ b/packages/node/test/handlers.test.ts
@@ -138,20 +138,20 @@ describe('parseRequest', () => {
   describe('parseRequest.transaction property', () => {
     test('extracts method and full route path by default from `originalUrl`', () => {
       const parsedRequest: Event = parseRequest({}, mockReq);
-      expect(parsedRequest.transaction).toEqual('POST|/some/originalUrl');
+      expect(parsedRequest.transaction).toEqual('POST /some/originalUrl');
     });
 
     test('extracts method and full route path by default from `url` if `originalUrl` is not present', () => {
       delete mockReq.originalUrl;
       const parsedRequest: Event = parseRequest({}, mockReq);
-      expect(parsedRequest.transaction).toEqual('POST|/some/url');
+      expect(parsedRequest.transaction).toEqual('POST /some/url');
     });
 
     test('fallback to method and `route.path` if previous attempts failed', () => {
       delete mockReq.originalUrl;
       delete mockReq.url;
       const parsedRequest: Event = parseRequest({}, mockReq);
-      expect(parsedRequest.transaction).toEqual('POST|/path');
+      expect(parsedRequest.transaction).toEqual('POST /path');
     });
 
     test('can extract path only instead if configured', () => {