Fix import of hoist-non-react-statics #2755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module uses a default export, so the star import is technically incorrect form: https://github.com/mridgway/hoist-non-react-statics/blob/f3de655212b47f20b9c6a27e89a60d23f358925a/src/index.js#L91 As a side effect, this causes build errors with Rollup: `(!) Cannot call a namespace ('hoistNonReactStatic')`
hoist-non-react-statics causes this issue, as it's built as a CommonJS module. This lets the default import function correctly on the transpiled build output in the npm module.
Contributor
Author
|
Ugh, looks like this is going to depend on #2756. If that can get merged in, I'll rebase this PR. Sorry about the hassle! |
Contributor
|
Thanks! I'll make sure everything is green before doing release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module uses a default export, so the star import is technically incorrect form: https://github.com/mridgway/hoist-non-react-statics/blob/f3de655212b47f20b9c6a27e89a60d23f358925a/src/index.js#L91
As a side effect, this causes build errors with Rollup:
(!) Cannot call a namespace ('hoistNonReactStatic')I think esModuleInterop is needed as well, but I'm going to see if CI passes without that first, as it might just be my local setup that's the issue.