Skip to content

Conversation

@HazAT
Copy link
Member

@HazAT HazAT commented Jun 3, 2020

@kamilogorek fix tests plz

@HazAT HazAT requested a review from kamilogorek as a code owner June 3, 2020 16:21
@getsentry-bot
Copy link
Contributor

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 16.9883 kB) (ES6: 16.0391 kB)

📖 ✅ TSLint passed

Generated by 🚫 dangerJS against 4c0260f

@kamilogorek kamilogorek removed their request for review June 4, 2020 10:19
@kamilogorek kamilogorek merged commit dcab5ef into master Jun 4, 2020
@kamilogorek kamilogorek deleted the better-dsn branch June 4, 2020 10:36
@Mnkras
Copy link

Mnkras commented Jun 8, 2020

Just a heads up, this check broke some stuff we were doing with proxying requests.
We were using the projectid to route to different endpoints, and use strings that aren't only numbers.

@Ilko89BG
Copy link

Ilko89BG commented Jun 9, 2020

(node:43) UnhandledPromiseRejectionWarning: SentryError: Invalid Dsn: Invalid projectId sentry
This what we have been getting after the release - I believe it has to do with this check!

@mitsuhiko
Copy link
Contributor

@Ilko89BG can you share the DSN you're using?

@mitsuhiko
Copy link
Contributor

So generally this has only been supported as an accident by this SDK. If you want to do something like this for routing where you cannot use an integer it would be better to use the path segment of a DSN which is supported.

So if you have https://[email protected]/foobar as DSN you could use https://[email protected]/foobar/1 instead (and use the 1 as a dummy project id).

@Ilko89BG
Copy link

Ilko89BG commented Jun 9, 2020

@Ilko89BG can you share the DSN you're using?

'http://sentry@localhost/sentry'

So generally this has only been supported as an accident by this SDK. If you want to do something like this for routing where you cannot use an integer it would be better to use the path segment of a DSN which is supported.

So if you have https://[email protected]/foobar as DSN you could use https://[email protected]/foobar/1 instead (and use the 1 as a dummy project id).

Ok will try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants