From c5ac37f843d336c145bbcc2b91a5bf56591457bf Mon Sep 17 00:00:00 2001 From: Patrizio Bertozzi Date: Thu, 19 Mar 2020 17:25:48 +0100 Subject: [PATCH 1/3] v0.0.0 --- package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 589f0db8cefd..c8bcee8c1697 100644 --- a/package.json +++ b/package.json @@ -62,5 +62,6 @@ }, "resolutions": { "**/agent-base": "5" - } + }, + "version": "0.0.0" } From 9e14f926244433e9d3f9a0f29b79206dc964db5d Mon Sep 17 00:00:00 2001 From: Patrizio Bertozzi Date: Thu, 19 Mar 2020 18:16:09 +0100 Subject: [PATCH 2/3] Move node runtime information to contexts.runtime --- packages/node/src/handlers.ts | 11 +++++++---- packages/node/test/handlers.test.ts | 19 +++++++++++++++++++ 2 files changed, 26 insertions(+), 4 deletions(-) diff --git a/packages/node/src/handlers.ts b/packages/node/src/handlers.ts index 9b97b6b2503a..f8bd934258c3 100644 --- a/packages/node/src/handlers.ts +++ b/packages/node/src/handlers.ts @@ -64,7 +64,7 @@ function extractTransaction(req: { [key: string]: any }, type: boolean | Transac stack: [ { name: string; - } + }, ]; }; }; @@ -240,9 +240,12 @@ export function parseRequest( }; if (options.version) { - event.extra = { - ...event.extra, - node: global.process.version, + event.contexts = { + ...event.contexts, + runtime: { + name: 'node', + version: global.process.version, + }, }; } diff --git a/packages/node/test/handlers.test.ts b/packages/node/test/handlers.test.ts index 431a9ae001b1..fc321f5b5cd2 100644 --- a/packages/node/test/handlers.test.ts +++ b/packages/node/test/handlers.test.ts @@ -18,6 +18,25 @@ describe('parseRequest', () => { }, }; + describe('parseRequest.contexts runtime', () => { + test('runtime name must contain node', () => { + const parsedRequest: Event = parseRequest({}, mockReq); + expect(parsedRequest.contexts.runtime.name).toEqual('node'); + }); + + test('runtime version must contain current node version', () => { + const parsedRequest: Event = parseRequest({}, mockReq); + expect(parsedRequest.contexts.runtime.version).toEqual(process.version); + }); + + test('runtime disbaled by options', () => { + const parsedRequest: Event = parseRequest({}, mockReq, { + version: false, + }); + expect(parsedRequest).not.toHaveProperty('contexts.runtime'); + }); + }); + describe('parseRequest.user properties', () => { const DEFAULT_USER_KEYS = ['id', 'username', 'email']; const CUSTOM_USER_KEYS = ['custom_property']; From b1cf25f44f52d88282cc546a5fe95140e18cb8c3 Mon Sep 17 00:00:00 2001 From: Patrizio Bertozzi Date: Fri, 20 Mar 2020 08:21:03 +0100 Subject: [PATCH 3/3] Fix lint warning --- packages/node/src/handlers.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/node/src/handlers.ts b/packages/node/src/handlers.ts index f8bd934258c3..d2fdc3c8c484 100644 --- a/packages/node/src/handlers.ts +++ b/packages/node/src/handlers.ts @@ -64,7 +64,7 @@ function extractTransaction(req: { [key: string]: any }, type: boolean | Transac stack: [ { name: string; - }, + } ]; }; };