Skip to content

Conversation

@rhcarvalho
Copy link
Contributor

Node.js v6 is old and lacks features we require to implement new SDK
features.

Node.js v6 is old and lacks features we require to implement new SDK
features.
@rhcarvalho rhcarvalho force-pushed the rhcarvalho/drop-node-6-support branch from d598a03 to cc7d177 Compare February 26, 2020 15:23
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Feb 26, 2020

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 16.7061 kB) (ES6: 15.7256 kB)

📖 ✅ TSLint passed

Generated by 🚫 dangerJS against 9376bb4

@kamilogorek
Copy link
Contributor

kamilogorek commented Feb 26, 2020

cc @HazAT. Node 6 is dead for almost a year now (it reached its end of life - no support provided), so I think it's fair to stop supporting it in newer releases.
It will affect APM only, but I think it's fair to add a note that we don't provide support for versions newer than 5.12.x

@kamilogorek kamilogorek mentioned this pull request Feb 27, 2020
@kamilogorek kamilogorek merged commit 4bdb330 into master Feb 27, 2020
@kamilogorek kamilogorek deleted the rhcarvalho/drop-node-6-support branch February 27, 2020 08:09
@Turbo87
Copy link
Contributor

Turbo87 commented Feb 28, 2020

FYI this update is causing issues for people that use yarn on CI systems that still test against old Node versions unless --ignore-engines is used. Would be great to do a major version bump next time support is dropped for a Node version to avoid these sorts of issues.

@kamilogorek
Copy link
Contributor

kamilogorek commented Feb 28, 2020

Sorry for trouble @Turbo87, it was an oversight on my side. Fix is already in place #2460
Will release it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants