Skip to content

Conversation

@lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Feb 13, 2020

There are currently three folders in the repo called manual, as part of the testing suites of raven-node, @sentry/node, and @sentry/browser, respectively:

https://github.com/getsentry/sentry-javascript/tree/5.12.3/packages/raven-node/test/manual
https://github.com/getsentry/sentry-javascript/tree/5.12.3/packages/node/test/manual
https://github.com/getsentry/sentry-javascript/tree/5.12.3/packages/browser/test/manual

For the first two folders, that name makes sense, as each houses an express app designed to let you manually trigger various scenarios and see how the SDK reacts. For the third, however, it doesn't, as that folder contains code designed to test @sentry/browser as a package (rather than just as a bundle). This PR renames the folder such that its name is more in line with its contents.

@getsentry-bot
Copy link
Contributor

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖 ✅ TSLint passed
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 16.7168 kB) (ES6: 15.7246 kB)

Generated by 🚫 dangerJS against a0d102f

@kamilogorek kamilogorek merged commit cb31b28 into master Feb 14, 2020
@kamilogorek kamilogorek deleted the kmclb-rename-manual-folder branch February 14, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants