From 2ac38214c416826e23a2f413a44ad35f800d745e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kamil=20Og=C3=B3rek?= Date: Thu, 7 Nov 2019 17:28:03 +0100 Subject: [PATCH] fix: Gracefuly handle incorrect input from onerror --- packages/browser/src/integrations/globalhandlers.ts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/browser/src/integrations/globalhandlers.ts b/packages/browser/src/integrations/globalhandlers.ts index e6fa65465244..e9294f6ea8ef 100644 --- a/packages/browser/src/integrations/globalhandlers.ts +++ b/packages/browser/src/integrations/globalhandlers.ts @@ -240,13 +240,17 @@ export class GlobalHandlers implements Integration { event.exception.values[0].stacktrace = event.exception.values[0].stacktrace || {}; event.exception.values[0].stacktrace.frames = event.exception.values[0].stacktrace.frames || []; + const colno = isNaN(parseInt(column, 10)) ? undefined : column; + const lineno = isNaN(parseInt(line, 10)) ? undefined : line; + const filename = isString(url) ? url : getLocationHref(); + if (event.exception.values[0].stacktrace.frames.length === 0) { event.exception.values[0].stacktrace.frames.push({ - colno: column, - filename: url || getLocationHref(), + colno, + filename, function: '?', in_app: true, - lineno: line, + lineno, }); }