From 953d1030ee5d8cfc6aae920b1336bba94e7cb477 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Fri, 12 Sep 2025 11:24:28 +0200 Subject: [PATCH] ref(astro): Adjust `mechanism` on error events captured by astro middleware --- .../astro-4/tests/errors.server.test.ts | 10 ++-------- .../astro-5/tests/errors.server.test.ts | 10 ++-------- packages/astro/src/server/middleware.ts | 5 +---- packages/astro/test/server/middleware.test.ts | 4 ++-- 4 files changed, 7 insertions(+), 22 deletions(-) diff --git a/dev-packages/e2e-tests/test-applications/astro-4/tests/errors.server.test.ts b/dev-packages/e2e-tests/test-applications/astro-4/tests/errors.server.test.ts index 3faacdb30090..f3b0e9a189de 100644 --- a/dev-packages/e2e-tests/test-applications/astro-4/tests/errors.server.test.ts +++ b/dev-packages/e2e-tests/test-applications/astro-4/tests/errors.server.test.ts @@ -47,11 +47,8 @@ test.describe('server-side errors', () => { values: [ { mechanism: { - data: { - function: 'astroMiddleware', - }, handled: false, - type: 'astro', + type: 'auto.middleware.astro', }, stacktrace: expect.any(Object), type: 'TypeError', @@ -136,11 +133,8 @@ test.describe('server-side errors', () => { values: [ { mechanism: { - data: { - function: 'astroMiddleware', - }, handled: false, - type: 'astro', + type: 'auto.middleware.astro', }, stacktrace: expect.any(Object), type: 'Error', diff --git a/dev-packages/e2e-tests/test-applications/astro-5/tests/errors.server.test.ts b/dev-packages/e2e-tests/test-applications/astro-5/tests/errors.server.test.ts index d6a9514da1d1..77d515ad2a24 100644 --- a/dev-packages/e2e-tests/test-applications/astro-5/tests/errors.server.test.ts +++ b/dev-packages/e2e-tests/test-applications/astro-5/tests/errors.server.test.ts @@ -47,11 +47,8 @@ test.describe('server-side errors', () => { values: [ { mechanism: { - data: { - function: 'astroMiddleware', - }, handled: false, - type: 'astro', + type: 'auto.middleware.astro', }, stacktrace: expect.any(Object), type: 'TypeError', @@ -136,11 +133,8 @@ test.describe('server-side errors', () => { values: [ { mechanism: { - data: { - function: 'astroMiddleware', - }, handled: false, - type: 'astro', + type: 'auto.middleware.astro', }, stacktrace: expect.any(Object), type: 'Error', diff --git a/packages/astro/src/server/middleware.ts b/packages/astro/src/server/middleware.ts index 61f7913cf1b1..a12c25ff6045 100644 --- a/packages/astro/src/server/middleware.ts +++ b/packages/astro/src/server/middleware.ts @@ -50,11 +50,8 @@ function sendErrorToSentry(e: unknown): unknown { captureException(objectifiedErr, { mechanism: { - type: 'astro', + type: 'auto.middleware.astro', handled: false, - data: { - function: 'astroMiddleware', - }, }, }); diff --git a/packages/astro/test/server/middleware.test.ts b/packages/astro/test/server/middleware.test.ts index 03933582c846..10e314268264 100644 --- a/packages/astro/test/server/middleware.test.ts +++ b/packages/astro/test/server/middleware.test.ts @@ -168,7 +168,7 @@ describe('sentryMiddleware', () => { await expect(async () => middleware(ctx, next)).rejects.toThrowError(); expect(captureExceptionSpy).toHaveBeenCalledWith(error, { - mechanism: { handled: false, type: 'astro', data: { function: 'astroMiddleware' } }, + mechanism: { handled: false, type: 'auto.middleware.astro' }, }); }); @@ -205,7 +205,7 @@ describe('sentryMiddleware', () => { await expect(() => resultFromNext!.text()).rejects.toThrowError(); expect(captureExceptionSpy).toHaveBeenCalledWith(error, { - mechanism: { handled: false, type: 'astro', data: { function: 'astroMiddleware' } }, + mechanism: { handled: false, type: 'auto.middleware.astro' }, }); });