ci: Fix canary test implosion #12915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 15, 2024 10:10
Lms24
approved these changes
Jul 15, 2024
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Hmm I have so many questions...
- why is this only now a problem?
- why does this fix things?
but thanks a lot for figuring it out!
Contributor
Author
I had the exact same questions but can not answer them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite random that this fixes it but 🤷 https://github.com/getsentry/sentry-javascript/actions/runs/9938503884
The nextjs 15 failures are actual failures I think
fixes #12905
fixes #12813
fixes #12906
fixes #12909
fixes #12902
fixes #12908