test(e2e): Add nestjs e2e test documenting errors not being properly caught in submodules #12868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicohrubec
changed the title
nicohrubec
changed the title
chargome
approved these changes
Jul 11, 2024
Member
chargome
left a comment
chargome
left a comment
There was a problem hiding this comment.
l: Calling the module and files "test" could be confusing with actual application testing (like in errors.test.ts). I would rather use "example" or something similar.
Member
Author
|
@chargome Missed the comment before merging but fair point will rename it in the next PR related to this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this issue.
Currently errors in submodules are not properly handled in nest applications if a custom exception filter extending the BaseExceptionFilter is used, leading to expected exceptions not being caught correctly and therefore being returned as 500 and sent to Sentry.
This expands the sample nest application and adds an e2e test that documents this behavior that can be used to check that future improvements to the SDK actually work. Of course the test has to be adjusted in that case.