From d45ae4d9c15acf9f3de44cc053ddb08a1d882937 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 8 Jul 2024 10:01:01 +0200 Subject: [PATCH 1/2] test(e2e): Run required E2E tests on PRs from forks --- .github/workflows/build.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a849469b69e3..38281568bba6 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -913,8 +913,7 @@ jobs: # - AND if the profiling node bindings were either successful or skipped if: | always() && needs.job_build.result == 'success' && - (needs.job_compile_bindings_profiling_node.result == 'success' || needs.job_compile_bindings_profiling_node.result == 'skipped') && - (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) + (needs.job_compile_bindings_profiling_node.result == 'success' || needs.job_compile_bindings_profiling_node.result == 'skipped') needs: [job_get_metadata, job_build, job_compile_bindings_profiling_node] runs-on: ubuntu-20.04-large-js timeout-minutes: 15 From cf8b53bfd5e710ebc0e36a5471fafb7ab0fbae8e Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 8 Jul 2024 13:45:43 +0200 Subject: [PATCH 2/2] move Astro Cloudflare rest to optional --- .github/workflows/build.yml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 38281568bba6..d1fab748707b 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -995,7 +995,6 @@ jobs: 'angular-17', 'angular-18', 'aws-lambda-layer-cjs', - 'cloudflare-astro', 'node-express', 'create-react-app', 'create-next-app', @@ -1113,16 +1112,6 @@ jobs: timeout-minutes: 5 run: pnpm test:assert - - name: Deploy Astro to Cloudflare - uses: cloudflare/pages-action@v1 - if: matrix.test-application == 'cloudflare-astro' - with: - apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }} - accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }} - projectName: ${{ secrets.CLOUDFLARE_PROJECT_NAME }} - directory: dist - workingDirectory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }} - job_optional_e2e_tests: name: E2E ${{ matrix.label || matrix.test-application }} Test # We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks @@ -1148,6 +1137,7 @@ jobs: matrix: test-application: [ + 'cloudflare-astro', 'react-send-to-sentry', 'node-express-send-to-sentry', 'debug-id-sourcemaps', @@ -1214,6 +1204,16 @@ jobs: timeout-minutes: 5 run: pnpm ${{ matrix.assert-command || 'test:assert' }} + - name: Deploy Astro to Cloudflare + uses: cloudflare/pages-action@v1 + if: matrix.test-application == 'cloudflare-astro' + with: + apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }} + accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }} + projectName: ${{ secrets.CLOUDFLARE_PROJECT_NAME }} + directory: dist + workingDirectory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }} + job_profiling_e2e_tests: name: E2E ${{ matrix.label || matrix.test-application }} Test # We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks