ci: Fix permissions for external contributors PRs (for real?) #12776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another day, another try to fix this!
Contributor
size-limit report 📦
|
lforst
reviewed
Jul 5, 2024
Contributor
lforst
left a comment
lforst
left a comment
There was a problem hiding this comment.
I think it is important to address the comment about only running this when PRs are merged, otherwise (I think!) people may open arbitrary PRs through the GH actions bot and I don't know whether that can lead to privilige escalation.
Contributor
There was a problem hiding this comment.
As discussed we should check the pr status for when it is merged, not just closed.
mydea
changed the title
lforst
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another day, another try to fix this!
Now it failed like this https://github.com/getsentry/sentry-javascript/actions/runs/9804811101/job/27073251966, hopefully this change fixes this... we'll see!