test: Add OTEL E2E test app using sdk-node #12690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+189
to
+193
| return fetch(sentryIngestUrl, { | ||
| body: proxyRequestBody, | ||
| headers: reqHeaders, | ||
| method: proxyRequest.method, | ||
| }).then(async res => { |
Check failure
Code scanning / CodeQL
Server-side request forgery
| // eslint-disable-next-line no-console | ||
| console.log( | ||
| '[event-proxy-server] Warn: No dsn on envelope header. Maybe a client-report was received. Proxy request body:', | ||
| proxyRequestBody, |
Check warning
Code scanning / CodeQL
Log injection
3 tasks
chargome
approved these changes
Jun 28, 2024
Member
chargome
left a comment
chargome
left a comment
There was a problem hiding this comment.
Nice! Good starting point for the remaining test setups I guess.
s1gr1d
approved these changes
Jun 28, 2024
Member
s1gr1d
left a comment
s1gr1d
left a comment
There was a problem hiding this comment.
Looks good, thanks for adding this test!
Would it make sense to also add one with .cjs?
Member
Author
We can def. do this! Though this is transpiled to cjs, so it is at least run with cjs already :) Using ts helps to also test that types etc. match everywhere correctly :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an E2E app using a custom OTEL setup with
@opentelemetry/sdk-node.It tests that data is sent both to sentry as well as to another OTLP exporter. For this, I adjusted the event proxy code to also allow to spin up a generic event proxy server (which I use for the OTLP exporter). I also rewrote this to use fetch as this is a bit easier to read IMHO.
This is a decent first step, we should add at least 2 more E2E test apps IMHO related to OTEL:
@opentelemetry/sdk-trace-nodeand some more custom tracing setup (e.g. more instrumentation, custom sampler, ....)@opentelemetry/sdk-trace-nodethat does not use Sentry for performance at all, but only for errors, and only uses OTEL for trace monitoring.Part of #12494