Skip to content

chore: Remove express integration comment from e2e tests #12241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2024
Merged

chore: Remove express integration comment from e2e tests #12241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a15746
chore: Remove express integration comment from e2e tests
AbhiPrasad May 27, 2024
77c4b49
more todo removed
AbhiPrasad May 27, 2024
a38e52c
Merge branch 'develop' into abhi-remove-comment-express
AbhiPrasad May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...de-integration-tests/suites/express/multiple-routers/common-infix-parameterized/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Sentry from '@sentry/node';
Sentry.init({
dsn: 'https://[email protected]/1337',
release: '1.0',
integrations: [
// TODO: This used to have the Express integration
],
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Expand Down
3 changes: 0 additions & 3 deletions dev-packages/node-integration-tests/suites/express/multiple-routers/common-infix/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Sentry from '@sentry/node';
Sentry.init({
dsn: 'https://[email protected]/1337',
release: '1.0',
integrations: [
// TODO: This used to have the Express integration
],
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Expand Down
3 changes: 0 additions & 3 deletions ...ation-tests/suites/express/multiple-routers/common-prefix-parameterized-reverse/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Sentry from '@sentry/node';
Sentry.init({
dsn: 'https://[email protected]/1337',
release: '1.0',
integrations: [
// TODO: This used to have the Express integration
],
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Expand Down
3 changes: 0 additions & 3 deletions ...e-integration-tests/suites/express/multiple-routers/common-prefix-parameterized/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Sentry from '@sentry/node';
Sentry.init({
dsn: 'https://[email protected]/1337',
release: '1.0',
integrations: [
// TODO: This used to use the Express integration
],
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Expand Down
3 changes: 0 additions & 3 deletions ...ts/suites/express/multiple-routers/common-prefix-same-length-parameterized copy/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Sentry from '@sentry/node';
Sentry.init({
dsn: 'https://[email protected]/1337',
release: '1.0',
integrations: [
// TODO: This used to have the Express integration
],
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Expand Down
3 changes: 0 additions & 3 deletions ...n-tests/suites/express/multiple-routers/common-prefix-same-length-parameterized/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Sentry from '@sentry/node';
Sentry.init({
dsn: 'https://[email protected]/1337',
release: '1.0',
integrations: [
// TODO: This used to have the Express integration
],
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Expand Down
3 changes: 0 additions & 3 deletions dev-packages/node-integration-tests/suites/express/multiple-routers/common-prefix/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Sentry from '@sentry/node';
Sentry.init({
dsn: 'https://[email protected]/1337',
release: '1.0',
integrations: [
// TODO: This used to have the Express integration
],
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Expand Down
3 changes: 0 additions & 3 deletions dev-packages/node-integration-tests/suites/express/multiple-routers/complex-router/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Sentry from '@sentry/node';
Sentry.init({
dsn: 'https://[email protected]/1337',
release: '1.0',
integrations: [
// TODO: This used to use the Express integration
],
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Expand Down
3 changes: 0 additions & 3 deletions ...de-integration-tests/suites/express/multiple-routers/middle-layer-parameterized/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import * as Sentry from '@sentry/node';
Sentry.init({
dsn: 'https://[email protected]/1337',
release: '1.0',
integrations: [
// TODO: This used to use the Express integration
],
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Expand Down
3 changes: 0 additions & 3 deletions dev-packages/node-integration-tests/suites/express/sentry-trace/baggage-header-out/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ Sentry.init({
release: '1.0',
environment: 'prod',
tracePropagationTargets: [/^(?!.*express).*$/],
integrations: [
// TODO: This used to use the Express integration
],
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Expand Down
3 changes: 0 additions & 3 deletions ...ion-tests/suites/express/sentry-trace/baggage-other-vendors-with-sentry-entries/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ Sentry.init({
environment: 'prod',
// disable requests to /express
tracePropagationTargets: [/^(?!.*express).*$/],
integrations: [
// TODO: This used to use the Express integration
],
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Expand Down
3 changes: 0 additions & 3 deletions ...ckages/node-integration-tests/suites/express/sentry-trace/baggage-other-vendors/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ Sentry.init({
environment: 'prod',
// disable requests to /express
tracePropagationTargets: [/^(?!.*express).*$/],
integrations: [
// TODO: This used to use the Express integration
],
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Expand Down
3 changes: 0 additions & 3 deletions ...ges/node-integration-tests/suites/express/sentry-trace/baggage-transaction-name/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ Sentry.init({
environment: 'prod',
// disable requests to /express
tracePropagationTargets: [/^(?!.*express).*$/],
integrations: [
// TODO: This used to use the Express integration
],
tracesSampleRate: 1.0,
// TODO: We're rethinking the mechanism for including Pii data in DSC, hence commenting out sendDefaultPii for now
// sendDefaultPii: true,
Expand Down
3 changes: 0 additions & 3 deletions dev-packages/node-integration-tests/suites/express/sentry-trace/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ Sentry.init({
release: '1.0',
environment: 'prod',
tracePropagationTargets: [/^(?!.*express).*$/],
integrations: [
// TODO: This used to use the Express integration
],
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Expand Down
3 changes: 0 additions & 3 deletions ...packages/node-integration-tests/suites/express/sentry-trace/trace-header-assign/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ Sentry.init({
dsn: 'https://[email protected]/1337',
release: '1.0',
environment: 'prod',
integrations: [
// TODO: This used to use the Express integration
],
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Expand Down