From 1930ff81e49718eecf8f671837bd8ebb437e2eec Mon Sep 17 00:00:00 2001 From: Ryan Albrecht Date: Mon, 20 May 2024 13:26:45 -0700 Subject: [PATCH 1/2] fix(feedback): Improve feedback border color in dark-mode, and prevent auto-dark mode when a theme is picked --- packages/feedback/src/core/createMainStyles.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/feedback/src/core/createMainStyles.ts b/packages/feedback/src/core/createMainStyles.ts index 95541ab4b06b..4ef1562eca42 100644 --- a/packages/feedback/src/core/createMainStyles.ts +++ b/packages/feedback/src/core/createMainStyles.ts @@ -27,7 +27,7 @@ const DEFAULT_DARK: InternalTheme = { accentBackground: PURPLE, successColor: '#2da98c', errorColor: '#f55459', - border: '1.5px solid rgba(41, 35, 47, 0.5)', + border: '1.5px solid rgba(180, 180, 180, 0.25)', boxShadow: '0px 4px 24px 0px rgba(43, 34, 51, 0.12)', outline: '1px auto var(--accent-background)', interactiveFilter: 'brightness(150%)', @@ -66,6 +66,8 @@ export function createMainStyles({ colorScheme, themeDark, themeLight }: Feedbac font-family: var(--font-family); font-size: var(--font-size); + ${colorScheme !== 'system' ? 'color-scheme: only light;' : ''} + ${getThemedCssVariables( colorScheme === 'dark' ? { ...DEFAULT_DARK, ...themeDark } : { ...DEFAULT_LIGHT, ...themeLight }, )} From 79a405ecc413e9871303cb90bf77631e73e79289 Mon Sep 17 00:00:00 2001 From: Ryan Albrecht Date: Tue, 21 May 2024 06:44:03 -0700 Subject: [PATCH 2/2] Update createMainStyles.ts --- packages/feedback/src/core/createMainStyles.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/feedback/src/core/createMainStyles.ts b/packages/feedback/src/core/createMainStyles.ts index 4ef1562eca42..68ac751b8584 100644 --- a/packages/feedback/src/core/createMainStyles.ts +++ b/packages/feedback/src/core/createMainStyles.ts @@ -27,7 +27,7 @@ const DEFAULT_DARK: InternalTheme = { accentBackground: PURPLE, successColor: '#2da98c', errorColor: '#f55459', - border: '1.5px solid rgba(180, 180, 180, 0.25)', + border: '1.5px solid rgba(235, 230, 239, 0.15)', boxShadow: '0px 4px 24px 0px rgba(43, 34, 51, 0.12)', outline: '1px auto var(--accent-background)', interactiveFilter: 'brightness(150%)',