From f2844ebff3ddf0f90390dda941bd7f42830130ea Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Tue, 7 May 2024 12:20:51 +0000 Subject: [PATCH 1/2] fix(browser): Continuously record CLS --- packages/browser-utils/src/metrics/instrument.ts | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/packages/browser-utils/src/metrics/instrument.ts b/packages/browser-utils/src/metrics/instrument.ts index ad390191266f..216d3e52692d 100644 --- a/packages/browser-utils/src/metrics/instrument.ts +++ b/packages/browser-utils/src/metrics/instrument.ts @@ -202,12 +202,15 @@ function triggerHandlers(type: InstrumentHandlerType, data: unknown): void { } function instrumentCls(): StopListening { - return onCLS(metric => { - triggerHandlers('cls', { - metric, - }); - _previousCls = metric; - }); + return onCLS( + metric => { + triggerHandlers('cls', { + metric, + }); + _previousCls = metric; + }, + { reportAllChanges: true }, + ); } function instrumentFid(): void { From 3e864bea48634acb32dda94cda6217f874e4b13f Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Tue, 7 May 2024 12:38:43 +0000 Subject: [PATCH 2/2] Add comment explaining --- packages/browser-utils/src/metrics/instrument.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/browser-utils/src/metrics/instrument.ts b/packages/browser-utils/src/metrics/instrument.ts index 216d3e52692d..acd3717e8bd4 100644 --- a/packages/browser-utils/src/metrics/instrument.ts +++ b/packages/browser-utils/src/metrics/instrument.ts @@ -209,6 +209,8 @@ function instrumentCls(): StopListening { }); _previousCls = metric; }, + // We want the callback to be called whenever the CLS value updates. + // By default, the callback is only called when the tab goes to the background. { reportAllChanges: true }, ); }