From bf8ec9b5739c002eb0f4bce905af2a613fa339d9 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Fri, 26 Apr 2024 13:49:42 +0200 Subject: [PATCH 1/2] ref(svelte): Use `onlyIfParent` for recording component update spans --- packages/svelte/src/performance.ts | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/packages/svelte/src/performance.ts b/packages/svelte/src/performance.ts index 100f9f732ddc..f59e1dba7153 100644 --- a/packages/svelte/src/performance.ts +++ b/packages/svelte/src/performance.ts @@ -59,13 +59,8 @@ function recordInitSpan(componentName: string): void { function recordUpdateSpans(componentName: string): void { let updateSpan: Span | undefined; beforeUpdate(() => { - // If there is no active span, we skip - const activeSpan = getActiveSpan(); - if (!activeSpan) { - return; - } - updateSpan = startInactiveSpan({ + onlyIfParent: true, op: UI_SVELTE_UPDATE, name: componentName, attributes: { [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.svelte' }, From 2b6fcbe0f7ac93a7127c98b9f0ab17d3c58230a6 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Fri, 26 Apr 2024 13:58:32 +0200 Subject: [PATCH 2/2] formatting --- packages/svelte/src/performance.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/svelte/src/performance.ts b/packages/svelte/src/performance.ts index f59e1dba7153..2bf23668c478 100644 --- a/packages/svelte/src/performance.ts +++ b/packages/svelte/src/performance.ts @@ -1,4 +1,4 @@ -import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, getActiveSpan } from '@sentry/browser'; +import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from '@sentry/browser'; import type { Span } from '@sentry/types'; import { afterUpdate, beforeUpdate, onMount } from 'svelte'; import { current_component } from 'svelte/internal';