From 426b67d95c464b1537b2c8c8dd370dbfdca3bf26 Mon Sep 17 00:00:00 2001
From: andrew0 <739172+andrew0@users.noreply.github.com>
Date: Thu, 25 Apr 2024 18:30:59 -0400
Subject: [PATCH 1/2] fix(core): Capture only failed console.assert calls

---
 packages/core/src/integrations/captureconsole.ts       | 10 ++++++----
 .../core/test/lib/integrations/captureconsole.test.ts  |  2 ++
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/packages/core/src/integrations/captureconsole.ts b/packages/core/src/integrations/captureconsole.ts
index 8e6dfc646419..3906a4806105 100644
--- a/packages/core/src/integrations/captureconsole.ts
+++ b/packages/core/src/integrations/captureconsole.ts
@@ -63,10 +63,12 @@ function consoleHandler(args: unknown[], level: string): void {
       return event;
     });
 
-    if (level === 'assert' && args[0] === false) {
-      const message = `Assertion failed: ${safeJoin(args.slice(1), ' ') || 'console.assert'}`;
-      scope.setExtra('arguments', args.slice(1));
-      captureMessage(message, captureContext);
+    if (level === 'assert') {
+      if (args[0] === false) {
+        const message = `Assertion failed: ${safeJoin(args.slice(1), ' ') || 'console.assert'}`;
+        scope.setExtra('arguments', args.slice(1));
+        captureMessage(message, captureContext);
+      }
       return;
     }
 
diff --git a/packages/core/test/lib/integrations/captureconsole.test.ts b/packages/core/test/lib/integrations/captureconsole.test.ts
index 6ed79d586c9c..66dd16c514b5 100644
--- a/packages/core/test/lib/integrations/captureconsole.test.ts
+++ b/packages/core/test/lib/integrations/captureconsole.test.ts
@@ -175,6 +175,8 @@ describe('CaptureConsole setup', () => {
     captureConsole.setup?.(mockClient);
 
     GLOBAL_OBJ.console.assert(1 + 1 === 2);
+
+    expect(captureMessage).toHaveBeenCalledTimes(0);
   });
 
   it('should capture exception when console logs an error object with level set to "error"', () => {

From 69c2a5545675e2e94736733e7594c6889d5a803e Mon Sep 17 00:00:00 2001
From: Francesco Novy <francesconovy@gmail.com>
Date: Fri, 26 Apr 2024 09:33:16 +0200
Subject: [PATCH 2/2] Update packages/core/src/integrations/captureconsole.ts

Co-authored-by: andrew0 <739172+andrew0@users.noreply.github.com>
---
 packages/core/src/integrations/captureconsole.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/core/src/integrations/captureconsole.ts b/packages/core/src/integrations/captureconsole.ts
index 3906a4806105..958040c1124f 100644
--- a/packages/core/src/integrations/captureconsole.ts
+++ b/packages/core/src/integrations/captureconsole.ts
@@ -64,7 +64,7 @@ function consoleHandler(args: unknown[], level: string): void {
     });
 
     if (level === 'assert') {
-      if (args[0] === false) {
+      if (!args[0]) {
         const message = `Assertion failed: ${safeJoin(args.slice(1), ' ') || 'console.assert'}`;
         scope.setExtra('arguments', args.slice(1));
         captureMessage(message, captureContext);