From fa8697c710fd94081daef5eca2c0ef30b4e747f6 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Mon, 15 Apr 2024 10:18:26 +0000 Subject: [PATCH] test(e2e): Unflake sveltekit e2e tests --- .../sveltekit-2/test/errors.client.test.ts | 10 +++++----- .../sveltekit/test/errors.client.test.ts | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/dev-packages/e2e-tests/test-applications/sveltekit-2/test/errors.client.test.ts b/dev-packages/e2e-tests/test-applications/sveltekit-2/test/errors.client.test.ts index 7942b96b41b0..36b2d34f0352 100644 --- a/dev-packages/e2e-tests/test-applications/sveltekit-2/test/errors.client.test.ts +++ b/dev-packages/e2e-tests/test-applications/sveltekit-2/test/errors.client.test.ts @@ -4,17 +4,17 @@ import { waitForInitialPageload } from './utils'; test.describe('client-side errors', () => { test('captures error thrown on click', async ({ page }) => { - await page.goto('/client-error'); - - await expect(page.getByText('Client error')).toBeVisible(); + await waitForInitialPageload(page, { route: '/client-error', debug: false }); const errorEventPromise = waitForError('sveltekit-2', errorEvent => { return errorEvent?.exception?.values?.[0]?.value === 'Click Error'; }); - const clickPromise = page.getByText('Throw error').click(); + await page.getByText('Throw error').click(); + + await expect(errorEventPromise).resolves.toBeDefined(); - const [errorEvent, _] = await Promise.all([errorEventPromise, clickPromise]); + const errorEvent = await errorEventPromise; const errorEventFrames = errorEvent.exception?.values?.[0]?.stacktrace?.frames; diff --git a/dev-packages/e2e-tests/test-applications/sveltekit/test/errors.client.test.ts b/dev-packages/e2e-tests/test-applications/sveltekit/test/errors.client.test.ts index 7cd1a545165b..50ade019350f 100644 --- a/dev-packages/e2e-tests/test-applications/sveltekit/test/errors.client.test.ts +++ b/dev-packages/e2e-tests/test-applications/sveltekit/test/errors.client.test.ts @@ -4,17 +4,17 @@ import { waitForInitialPageload } from '../utils'; test.describe('client-side errors', () => { test('captures error thrown on click', async ({ page }) => { - await page.goto('/client-error'); - - await expect(page.getByText('Client error')).toBeVisible(); + await waitForInitialPageload(page, { route: '/client-error', debug: false }); const errorEventPromise = waitForError('sveltekit', errorEvent => { return errorEvent?.exception?.values?.[0]?.value === 'Click Error'; }); - const clickPromise = page.getByText('Throw error').click(); + await page.getByText('Throw error').click(); + + await expect(errorEventPromise).resolves.toBeDefined(); - const [errorEvent, _] = await Promise.all([errorEventPromise, clickPromise]); + const errorEvent = await errorEventPromise; const errorEventFrames = errorEvent.exception?.values?.[0]?.stacktrace?.frames;