From af18fdd8c22925d3d1f5237fd44727734d7ccfe1 Mon Sep 17 00:00:00 2001
From: Lukas Stracke <lukas.stracke@sentry.io>
Date: Mon, 8 Apr 2024 10:52:14 +0200
Subject: [PATCH] test(e2e/sveltekit): Unflake client error test by waiting for
 hydration

---
 .../test-applications/sveltekit-2/test/errors.client.test.ts    | 2 +-
 .../e2e-tests/test-applications/sveltekit-2/test/utils.ts       | 2 +-
 .../test-applications/sveltekit/test/errors.client.test.ts      | 2 +-
 dev-packages/e2e-tests/test-applications/sveltekit/utils.ts     | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/dev-packages/e2e-tests/test-applications/sveltekit-2/test/errors.client.test.ts b/dev-packages/e2e-tests/test-applications/sveltekit-2/test/errors.client.test.ts
index 10bd64a097f2..eb83566a475d 100644
--- a/dev-packages/e2e-tests/test-applications/sveltekit-2/test/errors.client.test.ts
+++ b/dev-packages/e2e-tests/test-applications/sveltekit-2/test/errors.client.test.ts
@@ -4,7 +4,7 @@ import { waitForInitialPageload } from './utils';
 
 test.describe('client-side errors', () => {
   test('captures error thrown on click', async ({ page }) => {
-    await page.goto('/client-error');
+    await waitForInitialPageload(page, { route: '/client-error' });
 
     const errorEventPromise = waitForError('sveltekit-2', errorEvent => {
       return errorEvent?.exception?.values?.[0]?.value === 'Click Error';
diff --git a/dev-packages/e2e-tests/test-applications/sveltekit-2/test/utils.ts b/dev-packages/e2e-tests/test-applications/sveltekit-2/test/utils.ts
index 6aab192a18af..2fa35d9ae874 100644
--- a/dev-packages/e2e-tests/test-applications/sveltekit-2/test/utils.ts
+++ b/dev-packages/e2e-tests/test-applications/sveltekit-2/test/utils.ts
@@ -18,7 +18,7 @@ import { waitForTransaction } from '@sentry-internal/event-proxy-server';
  */
 export async function waitForInitialPageload(
   page: Page,
-  opts?: { route?: string; parameterizedRoute?: string; debug: boolean },
+  opts?: { route?: string; parameterizedRoute?: string; debug?: boolean },
 ) {
   const route = opts?.route ?? '/';
   const txnName = opts?.parameterizedRoute ?? route;
diff --git a/dev-packages/e2e-tests/test-applications/sveltekit/test/errors.client.test.ts b/dev-packages/e2e-tests/test-applications/sveltekit/test/errors.client.test.ts
index 47f4c9d9e380..7f0a5c50faa0 100644
--- a/dev-packages/e2e-tests/test-applications/sveltekit/test/errors.client.test.ts
+++ b/dev-packages/e2e-tests/test-applications/sveltekit/test/errors.client.test.ts
@@ -4,7 +4,7 @@ import { waitForInitialPageload } from '../utils';
 
 test.describe('client-side errors', () => {
   test('captures error thrown on click', async ({ page }) => {
-    await page.goto('/client-error');
+    await waitForInitialPageload(page, { route: '/client-error' });
 
     const errorEventPromise = waitForError('sveltekit', errorEvent => {
       return errorEvent?.exception?.values?.[0]?.value === 'Click Error';
diff --git a/dev-packages/e2e-tests/test-applications/sveltekit/utils.ts b/dev-packages/e2e-tests/test-applications/sveltekit/utils.ts
index a056c030a491..c919c1d72e95 100644
--- a/dev-packages/e2e-tests/test-applications/sveltekit/utils.ts
+++ b/dev-packages/e2e-tests/test-applications/sveltekit/utils.ts
@@ -18,7 +18,7 @@ import { waitForTransaction } from '@sentry-internal/event-proxy-server';
  */
 export async function waitForInitialPageload(
   page: Page,
-  opts?: { route?: string; parameterizedRoute?: string; debug: boolean },
+  opts?: { route?: string; parameterizedRoute?: string; debug?: boolean },
 ) {
   const route = opts?.route ?? '/';
   const txnName = opts?.parameterizedRoute ?? route;