From 0b653643415e0be46ef84e40b77161d34f13170a Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Thu, 28 Mar 2024 08:20:22 +0000 Subject: [PATCH 1/2] fix(tracing-internal/v7): Guard for missing navigation performance entries --- packages/tracing-internal/src/browser/metrics/index.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/tracing-internal/src/browser/metrics/index.ts b/packages/tracing-internal/src/browser/metrics/index.ts index 778d0a3b28cc..26316d79baae 100644 --- a/packages/tracing-internal/src/browser/metrics/index.ts +++ b/packages/tracing-internal/src/browser/metrics/index.ts @@ -674,7 +674,12 @@ function setResourceEntrySizeData( * ttfb information is added via vendored web vitals library. */ function _addTtfbRequestTimeToMeasurements(_measurements: Measurements): void { - const navEntry = getNavigationEntry() as TTFBMetric['entries'][number]; + const navEntry = getNavigationEntry(); + + if (!navEntry) { + return; + } + const { responseStart, requestStart } = navEntry; if (requestStart <= responseStart) { From 5914aa4efa363adc89ed66a1dc2b483e5df1eb74 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Thu, 28 Mar 2024 08:27:12 +0000 Subject: [PATCH 2/2] lint --- packages/tracing-internal/src/browser/metrics/index.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/tracing-internal/src/browser/metrics/index.ts b/packages/tracing-internal/src/browser/metrics/index.ts index 26316d79baae..67eac414530e 100644 --- a/packages/tracing-internal/src/browser/metrics/index.ts +++ b/packages/tracing-internal/src/browser/metrics/index.ts @@ -32,7 +32,6 @@ import { _startChild, isMeasurementValue } from './utils'; import { createSpanEnvelope } from '@sentry/core'; import { getNavigationEntry } from '../web-vitals/lib/getNavigationEntry'; -import type { TTFBMetric } from '../web-vitals/types/ttfb'; const MAX_INT_AS_BYTES = 2147483647;