feat(react): Update scope's transactionName in React Router instrumentations
#11048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the base branch from
develop
to
lms/feat-browser-scope-setTransactionName
Lms24
changed the title
transactionName in router instrumentationstransactionName in React Router instrumentations
mydea
approved these changes
Mar 12, 2024
Base automatically changed from
lms/feat-browser-scope-setTransactionName
to
develop
March 12, 2024 14:52
Lms24
force-pushed
the
lms/feat-react-auto-update-transactionName
branch
from
9d16569 to
7680875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds updating of the current scope's
transactionNamevalue to our React Router instrumentations (i.e.reactRoutervXbrowserTracingIntegrations).Only the v4/5 and v6 integrations needed changes because v3 doesn't retroactively update a transaction name either. We only have to care about transaction name updates here because the
start(Pageload|Navigation)Spanhelper functions already set the initial name onto the scope (via #10992).Added unit tests to all RR versions.
Before merging, I'll add an e2e to one of our RR6 e2e test appsActually, this requires some changes to our react e2e test fixture. I'll open a follow-up PR to keep things simpler.ref: #10846