feat(profiling-node): Refactor deprecated methods & non-hook variant #10984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all clients have hooks now, we only have this single method for instrumentation left. I also refactored this to not use `startTransaction` / `finishTransaction` anymore, but instead use `spanStart` & `spanEnd`.
AbhiPrasad
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all clients have hooks now, we only have this single method for instrumentation left.
I also refactored this to not use
startTransaction/finishTransactionanymore, but instead usespanStart&spanEnd. Everything is now centered around spans, also profiling, this just looks at root spans now, which should be functionally the same.I have not checked if there is any behavior that used to be only tested in non-hook tests - I simply deleted all non-hooks-only tests. (some of the general ones I just refactored to the hooks version, as far as this was visible from the test structure/naming).