From 0fd5d76d40cff7cd17ce683ad3ed848564eeb4de Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Tue, 27 Feb 2024 15:59:18 -0500 Subject: [PATCH] chore(v8): Clean up some dead code - test we forgot to delete fully - comments that don't apply anymore --- .../browserTracingIntegration/http-timings/test.ts | 1 - .../customTargetsAndOrigins/init.js | 9 --------- .../tracePropagationTargets/customTracingOrigins/init.js | 9 --------- packages/types/src/client.ts | 1 - 4 files changed, 20 deletions(-) delete mode 100644 dev-packages/browser-integration-tests/suites/tracing/browsertracing/tracePropagationTargets/customTargetsAndOrigins/init.js delete mode 100644 dev-packages/browser-integration-tests/suites/tracing/browsertracing/tracePropagationTargets/customTracingOrigins/init.js diff --git a/dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/http-timings/test.ts b/dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/http-timings/test.ts index b6da7522d82c..467507fa6f75 100644 --- a/dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/http-timings/test.ts +++ b/dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/http-timings/test.ts @@ -26,7 +26,6 @@ sentryTest('should create fetch spans with http timing @firefox', async ({ brows const envelopes = await getMultipleSentryEnvelopeRequests(page, 2, { url, timeout: 10000 }); const tracingEvent = envelopes[envelopes.length - 1]; // last envelope contains tracing data on all browsers - // eslint-disable-next-line deprecation/deprecation const requestSpans = tracingEvent.spans?.filter(({ op }) => op === 'http.client'); expect(requestSpans).toHaveLength(3); diff --git a/dev-packages/browser-integration-tests/suites/tracing/browsertracing/tracePropagationTargets/customTargetsAndOrigins/init.js b/dev-packages/browser-integration-tests/suites/tracing/browsertracing/tracePropagationTargets/customTargetsAndOrigins/init.js deleted file mode 100644 index d4fd36f8302c..000000000000 --- a/dev-packages/browser-integration-tests/suites/tracing/browsertracing/tracePropagationTargets/customTargetsAndOrigins/init.js +++ /dev/null @@ -1,9 +0,0 @@ -import * as Sentry from '@sentry/browser'; - -window.Sentry = Sentry; - -Sentry.init({ - dsn: 'https://public@dsn.ingest.sentry.io/1337', - integrations: [new Sentry.BrowserTracing({ tracePropagationTargets: [], tracingOrigins: ['http://example.com'] })], - tracesSampleRate: 1, -}); diff --git a/dev-packages/browser-integration-tests/suites/tracing/browsertracing/tracePropagationTargets/customTracingOrigins/init.js b/dev-packages/browser-integration-tests/suites/tracing/browsertracing/tracePropagationTargets/customTracingOrigins/init.js deleted file mode 100644 index c43686bbc598..000000000000 --- a/dev-packages/browser-integration-tests/suites/tracing/browsertracing/tracePropagationTargets/customTracingOrigins/init.js +++ /dev/null @@ -1,9 +0,0 @@ -import * as Sentry from '@sentry/browser'; - -window.Sentry = Sentry; - -Sentry.init({ - dsn: 'https://public@dsn.ingest.sentry.io/1337', - integrations: [new Sentry.BrowserTracing({ tracingOrigins: ['http://example.com'] })], - tracesSampleRate: 1, -}); diff --git a/packages/types/src/client.ts b/packages/types/src/client.ts index 4d41b0f216bd..1bd423116e8f 100644 --- a/packages/types/src/client.ts +++ b/packages/types/src/client.ts @@ -179,7 +179,6 @@ export interface Client { recordDroppedEvent(reason: EventDropReason, dataCategory: DataCategory, event?: Event): void; // HOOKS - // TODO(v8): Make the hooks non-optional. /* eslint-disable @typescript-eslint/unified-signatures */ /**