From 952f0f8fd1a0abe7294c0480bde53b8e6fa31686 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Thu, 22 Feb 2024 11:01:09 +0100 Subject: [PATCH 1/3] feat(hub): Remove `@sentry/hub` package (for real this time) --- .craft.yml | 3 --- .../e2e-tests/verdaccio-config/config.yaml | 6 ----- packages/hub/LICENSE | 14 ---------- packages/hub/README.md | 21 --------------- packages/hub/package.json | 26 ------------------- packages/replay/src/replay.ts | 2 ++ 6 files changed, 2 insertions(+), 70 deletions(-) delete mode 100644 packages/hub/LICENSE delete mode 100644 packages/hub/README.md delete mode 100644 packages/hub/package.json diff --git a/.craft.yml b/.craft.yml index 99efaf3d095e..f795d317b05e 100644 --- a/.craft.yml +++ b/.craft.yml @@ -132,9 +132,6 @@ targets: includeNames: /^sentry-internal-eslint-config-sdk-\d.*\.tgz$/ ## 8. Deprecated packages we still release (but no packages depend on them anymore) - - name: npm - id: '@sentry/hub' - includeNames: /^sentry-hub-\d.*\.tgz$/ - name: npm id: '@sentry/tracing' includeNames: /^sentry-tracing-\d.*\.tgz$/ diff --git a/dev-packages/e2e-tests/verdaccio-config/config.yaml b/dev-packages/e2e-tests/verdaccio-config/config.yaml index 4952397bc706..143596b74849 100644 --- a/dev-packages/e2e-tests/verdaccio-config/config.yaml +++ b/dev-packages/e2e-tests/verdaccio-config/config.yaml @@ -200,12 +200,6 @@ packages: unpublish: $all # proxy: npmjs # Don't proxy for E2E tests! - '@sentry/hub': - access: $all - publish: $all - unpublish: $all - # proxy: npmjs # Don't proxy for E2E tests! - '@sentry-internal/*': access: $all publish: $all diff --git a/packages/hub/LICENSE b/packages/hub/LICENSE deleted file mode 100644 index 535ef0561e1b..000000000000 --- a/packages/hub/LICENSE +++ /dev/null @@ -1,14 +0,0 @@ -Copyright (c) 2019 Sentry (https://sentry.io) and individual contributors. All rights reserved. - -Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated -documentation files (the "Software"), to deal in the Software without restriction, including without limitation the -rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit -persons to whom the Software is furnished to do so, subject to the following conditions: - -The above copyright notice and this permission notice shall be included in all copies or substantial portions of the -Software. - -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE -WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR -COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR -OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. diff --git a/packages/hub/README.md b/packages/hub/README.md deleted file mode 100644 index 91f796ac0b68..000000000000 --- a/packages/hub/README.md +++ /dev/null @@ -1,21 +0,0 @@ -

- - Sentry - -

- -# Sentry JavaScript SDK Hub - -[![npm version](https://img.shields.io/npm/v/@sentry/hub.svg)](https://www.npmjs.com/package/@sentry/hub) -[![npm dm](https://img.shields.io/npm/dm/@sentry/hub.svg)](https://www.npmjs.com/package/@sentry/hub) -[![npm dt](https://img.shields.io/npm/dt/@sentry/hub.svg)](https://www.npmjs.com/package/@sentry/hub) - -## Links - -- [Official SDK Docs](https://docs.sentry.io/quickstart/) -- [TypeDoc](http://getsentry.github.io/sentry-javascript/) - -## IMPORTANT - -This package only exists anymore to enable a seamless publishing process between v7 and v8 of the JS SDK packages. It -will be removed in a future version. diff --git a/packages/hub/package.json b/packages/hub/package.json deleted file mode 100644 index 982e739a680e..000000000000 --- a/packages/hub/package.json +++ /dev/null @@ -1,26 +0,0 @@ -{ - "name": "@sentry/hub", - "version": "7.100.0", - "description": "Placeholder package for the former @sentry/hub package for publishing", - "repository": "git://github.com/getsentry/sentry-javascript.git", - "homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/hub", - "author": "Sentry", - "license": "MIT", - "engines": { - "node": ">=14" - }, - "files": [], - "publishConfig": { - "access": "public" - }, - "scripts": { - "build": "mkdir -p build && touch build/dummy.js", - "build:transpile": "yarn build", - "build:tarball": "ts-node ../../scripts/prepack.ts && npm pack ./build", - "clean": "rimraf build coverage sentry-hub-*.tgz" - }, - "volta": { - "extends": "../../package.json" - }, - "sideEffects": false -} diff --git a/packages/replay/src/replay.ts b/packages/replay/src/replay.ts index 30ccda422544..e3a6393dc196 100644 --- a/packages/replay/src/replay.ts +++ b/packages/replay/src/replay.ts @@ -284,6 +284,8 @@ export class ReplayContainer implements ReplayContainerInterface { * _performanceObserver, Recording, Sentry SDK, etc) */ public start(): void { + console.log('REPLAY START'); + if (this._isEnabled && this.recordingMode === 'session') { throw new Error('Replay recording is already in progress'); } From 91bb36c198a495b6d338c94ed758cd09c1a3ae49 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Thu, 22 Feb 2024 11:08:04 +0100 Subject: [PATCH 2/3] cleanup --- packages/replay/src/replay.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/replay/src/replay.ts b/packages/replay/src/replay.ts index e3a6393dc196..30ccda422544 100644 --- a/packages/replay/src/replay.ts +++ b/packages/replay/src/replay.ts @@ -284,8 +284,6 @@ export class ReplayContainer implements ReplayContainerInterface { * _performanceObserver, Recording, Sentry SDK, etc) */ public start(): void { - console.log('REPLAY START'); - if (this._isEnabled && this.recordingMode === 'session') { throw new Error('Replay recording is already in progress'); } From c970734fd6cddc1f78c2ca4cf1b02dc9d522c4d6 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Thu, 22 Feb 2024 12:53:31 +0100 Subject: [PATCH 3/3] remove hub from workspace --- package.json | 1 - 1 file changed, 1 deletion(-) diff --git a/package.json b/package.json index 9ecacd34c252..74fbfe2a650f 100644 --- a/package.json +++ b/package.json @@ -57,7 +57,6 @@ "packages/eslint-plugin-sdk", "packages/feedback", "packages/gatsby", - "packages/hub", "packages/integrations", "packages/integration-shims", "packages/nextjs",