feat(integrations): Capture error arguments as exception regardless of level in captureConsoleIntegration
#10744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
changed the title
Contributor
Author
|
Thanks for the title change. Got confused there as I was also working on a custom node integration. |
GingerAdonis
force-pushed
the
patch-1
branch
from
c4bacab to
04301b7
Compare
GingerAdonis
changed the title
Member
|
I guess this is a breaking change, so we can release it as part of v8. |
lforst
changed the title
captureConsoleIntegration
AbhiPrasad
pushed a commit
that referenced
this pull request
Feb 21, 2024
…f level in `captureConsoleIntegration` (#10744)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows
console.warn(new Error('Hello'))(and other severity levels) to be captured as an exception instead of a message. This was already the case forconsole.error.Discussed this PR with @lforst on Discord.