diff --git a/packages/core/src/tracing/sentrySpan.ts b/packages/core/src/tracing/sentrySpan.ts index 425ded18713b..f8bc6ca6d77b 100644 --- a/packages/core/src/tracing/sentrySpan.ts +++ b/packages/core/src/tracing/sentrySpan.ts @@ -497,15 +497,6 @@ export class SentrySpan implements SpanInterface { return this; } - /** - * @inheritDoc - * - * @deprecated Use `spanToJSON(span).status === 'ok'` instead. - */ - public isSuccess(): boolean { - return this._status === 'ok'; - } - /** * @inheritDoc * diff --git a/packages/tracing/test/span.test.ts b/packages/tracing/test/span.test.ts index 8975b3762a64..671310d49744 100644 --- a/packages/tracing/test/span.test.ts +++ b/packages/tracing/test/span.test.ts @@ -123,31 +123,6 @@ describe('SentrySpan', () => { expect(span.tags['http.status_code']).toBe('404'); expect(span.data['http.response.status_code']).toBe(404); }); - - // TODO (v8): Remove - test('isSuccess', () => { - const span = new SentrySpan({}); - expect(span.isSuccess()).toBe(false); - expect(spanToJSON(span).status).not.toBe('ok'); - span.setHttpStatus(200); - expect(span.isSuccess()).toBe(true); - expect(spanToJSON(span).status).toBe('ok'); - span.setStatus('permission_denied'); - expect(span.isSuccess()).toBe(false); - expect(spanToJSON(span).status).not.toBe('ok'); - span.setHttpStatus(0); - expect(span.isSuccess()).toBe(false); - expect(spanToJSON(span).status).not.toBe('ok'); - span.setHttpStatus(-1); - expect(span.isSuccess()).toBe(false); - expect(spanToJSON(span).status).not.toBe('ok'); - span.setHttpStatus(99); - expect(span.isSuccess()).toBe(false); - expect(spanToJSON(span).status).not.toBe('ok'); - span.setHttpStatus(100); - expect(span.isSuccess()).toBe(true); - expect(spanToJSON(span).status).toBe('ok'); - }); }); describe('toTraceparent', () => { diff --git a/packages/types/src/span.ts b/packages/types/src/span.ts index 69704d497b8f..408b593ab5d2 100644 --- a/packages/types/src/span.ts +++ b/packages/types/src/span.ts @@ -365,13 +365,6 @@ export interface Span extends Omit { */ startChild(spanContext?: Pick>): Span; - /** - * Determines whether span was successful (HTTP200) - * - * @deprecated Use `spanToJSON(span).status === 'ok'` instead. - */ - isSuccess(): boolean; - /** * Return a traceparent compatible header string. * @deprecated Use `spanToTraceHeader()` instead.