Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Feb 12, 2024

This allows us to simplify things, for now - we may add this back later in a more generic way, when/if we add the events to our shared span interface.

This allows us to simplify things, for now - we may add this back later in a more generic way, when/if we add the events to our shared span interface.
@mydea mydea requested review from AbhiPrasad, Lms24 and lforst February 12, 2024 12:52
@mydea mydea self-assigned this Feb 12, 2024
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I was just wondering: Was this a PoC how we'd handle span events in the SDK/in Sentry or was there a concrete use case for this functionality?

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.9 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.13 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.05 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.74 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.31 KB (+0.18% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.16 KB (+0.19% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.17 KB (+0.1% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.16 KB (+0.1% 🔺)
@sentry/browser - Webpack (gzipped) 22.44 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.88 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.43 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.38 KB (+0.11% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.48 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.61 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.16 KB (+0.22% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.57 KB (+0.3% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.62 KB (+0.29% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.49 KB (+0.04% 🔺)
@sentry/react - Webpack (gzipped) 22.47 KB (+0.12% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.31 KB (+0.11% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.42 KB (+0.2% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.11 KB (0%)

@mydea
Copy link
Member Author

mydea commented Feb 12, 2024

LGTM but I was just wondering: Was this a PoC how we'd handle span events in the SDK/in Sentry or was there a concrete use case for this functionality?

Originally we kept all breadcrumbs as events on the root span for otel (which was also a bit hacky...) With the isolation scopes, this is not needed anymore as we can just keep them there (same as for the "regular" SDKs), so we can get rid of this.

There may still be value in capturing these, e.g. if some otel auto instrumentation adds events we can also have them somehow in our system. But we can think about this properly and add this when we know how we want this, actually.

@mydea mydea merged commit 11d854e into develop Feb 12, 2024
@mydea mydea deleted the fn/otel-span-events branch February 12, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants