Skip to content

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented Feb 9, 2024

Makes the hub addBreadcrumb method add the breadcrumb to the hubs isolation scope instead of scope. As ofhttps://github.com//pull/10601, this code path is not used anymore but we should align behaviour for the migration.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.86 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.1 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.02 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.71 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.29 KB (-0.04% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.15 KB (-0.04% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.16 KB (-0.03% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.16 KB (-0.02% 🔽)
@sentry/browser - Webpack (gzipped) 22.43 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.84 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.4 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.36 KB (-0.05% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.46 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.38 KB (-0.11% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101 KB (-0.16% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.41 KB (-0.22% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.59 KB (-0.11% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.46 KB (-0.05% 🔽)
@sentry/react - Webpack (gzipped) 22.46 KB (-0.04% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.25 KB (-0.07% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.38 KB (-0.09% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.1 KB (-0.02% 🔽)

@lforst lforst marked this pull request as ready for review February 12, 2024 14:44
@lforst lforst requested review from AbhiPrasad, Lms24 and mydea February 12, 2024 14:45
@lforst lforst merged commit 19c8527 into develop Feb 12, 2024
@lforst lforst deleted the lforst-breadcrumbs-on-isolation-scope branch February 12, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants