From 597ffedd67339d411da1025eb0b2f4c56a1973b9 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Tue, 30 Jan 2024 13:42:40 +0000 Subject: [PATCH 1/4] ci: Use larger runners for playwright tests --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 62b713e73def..91096d88e76d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -548,7 +548,7 @@ jobs: name: Playwright (${{ matrix.bundle }}) Tests needs: [job_get_metadata, job_build] if: needs.job_get_metadata.outputs.changed_browser_integration == 'true' || github.event_name != 'pull_request' - runs-on: ubuntu-20.04 + runs-on: ubuntu-20.04-large-js timeout-minutes: 25 strategy: fail-fast: false From bdfb54364d812696b3f0408f61b0955d6eaa095f Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Tue, 30 Jan 2024 13:56:34 +0000 Subject: [PATCH 2/4] Also beefier runner on prepare e2e tests bc it is a bottleneck --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 91096d88e76d..1889f62cfe99 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -840,7 +840,7 @@ jobs: (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && github.actor != 'dependabot[bot]' needs: [job_get_metadata, job_build] - runs-on: ubuntu-20.04 + runs-on: ubuntu-20.04-large-js timeout-minutes: 15 steps: - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) From 80d5e53454bb4f60f737b05a490763843922eafe Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Tue, 30 Jan 2024 14:09:49 +0000 Subject: [PATCH 3/4] stupid test --- .../tracing/browserTracingIntegration/interactions/test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/interactions/test.ts b/dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/interactions/test.ts index 131403756251..50c095dbcc57 100644 --- a/dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/interactions/test.ts +++ b/dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/interactions/test.ts @@ -51,7 +51,7 @@ sentryTest('should capture interaction transaction. @firefox', async ({ browserN expect(interactionSpan.timestamp).toBeDefined(); const interactionSpanDuration = (interactionSpan.timestamp! - interactionSpan.start_timestamp) * 1000; - expect(interactionSpanDuration).toBeGreaterThan(70); + expect(interactionSpanDuration).toBeGreaterThan(65); expect(interactionSpanDuration).toBeLessThan(200); }); From cf3aad3c56c771c71230d9ee8234135507c77439 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Tue, 30 Jan 2024 16:02:54 +0100 Subject: [PATCH 4/4] larger runner for build --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1889f62cfe99..246e67a6be88 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -670,7 +670,7 @@ jobs: name: Browser (${{ matrix.browser }}) Tests needs: [job_get_metadata, job_build] if: needs.job_get_metadata.outputs.changed_browser == 'true' || github.event_name != 'pull_request' - runs-on: ubuntu-20.04 + runs-on: ubuntu-20.04-large-js timeout-minutes: 20 strategy: fail-fast: false