Skip to content

test(tracing): Add test to validate that spans only added when active span exists #10376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

test(tracing): Add test to validate that spans only added when active span exists #10376

wants to merge 5 commits into from

Conversation

@AbhiPrasad
Copy link
Member

Test for #10375

@AbhiPrasad AbhiPrasad requested review from a team, Lms24 and lforst and removed request for a team January 26, 2024 18:53
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.12 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.33 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.22 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.95 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.35 KB (-0.09% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.2 KB (-0.22% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.33 KB (+0.01% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.34 KB (+0.01% 🔺)
@sentry/browser - Webpack (gzipped) 22.6 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.89 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.44 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.32 KB (-0.14% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.51 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.53 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 100.54 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.44 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.4 KB (-0.17% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.73 KB (-0.04% 🔽)
@sentry/react - Webpack (gzipped) 22.63 KB (-0.02% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.4 KB (-0.04% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.7 KB (-0.05% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (-0.04% 🔽)

@mydea mydea mentioned this pull request Jan 29, 2024
Merged
Base automatically changed from abhi-span-request-active to develop January 29, 2024 20:33
@AbhiPrasad AbhiPrasad force-pushed the abhi-span-request-test branch 2 times, most recently from 247acb5 to 67296f1 Compare January 29, 2024 22:24
mydea added a commit that referenced this pull request Jan 30, 2024
@mydea
feat(core): Ensure startSpan() can handle spans that require parent (…
1822af5 
…#10386)

This introduces a new `onlyIfParent` option to the start-span APIs,
which, if set, will ensure to not create a span if there is no parent.
I've added this also for otel to demonstrate this works there as well.

This PR also uses this option in a few places, esp. for http.client
spans, to ensure we do not capture these if there is no ongoing
transaction.

This replaces
https://github.com/getsentry/sentry-javascript/pull/10375/files with a
more generic solution, and includes the test from
#10376 (which passes
here as well).
@mydea
Copy link
Member

mydea commented Jan 30, 2024

these have been picked & merged into #10386, so I'll close this!

@mydea mydea closed this Jan 30, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-span-request-test branch February 21, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydea mydea mydea approved these changes

@lforst lforst Awaiting requested review from lforst lforst was automatically assigned from getsentry/team-javascript-sdks

@Lms24 Lms24 Awaiting requested review from Lms24 Lms24 was automatically assigned from getsentry/team-javascript-sdks

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AbhiPrasad @mydea