From d4db82ad2fabc7d47488d47838b72e7aae3fa1a9 Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Thu, 4 Jan 2024 18:03:43 -0500 Subject: [PATCH 1/2] fix(cron): Make name required for instrumentNodeCron option --- packages/node/src/cron/node-cron.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/node/src/cron/node-cron.ts b/packages/node/src/cron/node-cron.ts index 2f422b9a85f8..4495a0b54909 100644 --- a/packages/node/src/cron/node-cron.ts +++ b/packages/node/src/cron/node-cron.ts @@ -2,12 +2,12 @@ import { withMonitor } from '@sentry/core'; import { replaceCronNames } from './common'; export interface NodeCronOptions { - name?: string; + name: string; timezone?: string; } export interface NodeCron { - schedule: (cronExpression: string, callback: () => void, options?: NodeCronOptions) => unknown; + schedule: (cronExpression: string, callback: () => void, options: NodeCronOptions) => unknown; } /** From d088776fa7d098a751e85077dd9f85a47dd5fb87 Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Fri, 5 Jan 2024 12:56:38 -0500 Subject: [PATCH 2/2] add ts expect error --- packages/node/test/cron.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/node/test/cron.test.ts b/packages/node/test/cron.test.ts index d37fcf189926..8f479e7a16d4 100644 --- a/packages/node/test/cron.test.ts +++ b/packages/node/test/cron.test.ts @@ -118,6 +118,7 @@ describe('cron check-ins', () => { const cronWithCheckIn = cron.instrumentNodeCron(nodeCron); expect(() => { + // @ts-expect-error Initially missing name cronWithCheckIn.schedule('* * * * *', () => { // });